Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

Jeremy Huddleston Sequoia writes: > I thought we required C99 now. Was I mistaken in that? If not, I'm > fine with just leaving it as is and ignoring the warning. We're not (yet) allowing mixed declarations and code. To get rid of the warning (a good idea), you'll just

[PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

osinit.c:161:24: warning: unused variable 'devnull' [-Wunused-variable,Unused Entity Issue] static const char *devnull = "/dev/null"; ^ osinit.c:162:10: warning: unused variable 'fname' [-Wunused-variable,Unused Entity Issue] char fname[PATH_MAX]; ^

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

I thought we required C99 now. Was I mistaken in that? If not, I'm fine with just leaving it as is and ignoring the warning. > On Oct 14, 2015, at 15:37, Alan Coopersmith > wrote: > > I don't mind not having the declarations at the beginning of the block > but

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

I don't mind not having the declarations at the beginning of the block but will that make some other platforms with ancient compilers sad? (OpenBSD with old gcc? Visual Studio on Windows?) -alan- On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: osinit.c:161:24: warning: unused