Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-30 Thread Olivier Fourdan
Hi Lyude, On Tue, May 29, 2018 at 7:54 PM, Lyude Paul wrote: > On Mon, 2018-05-28 at 09:11 +0200, Olivier Fourdan wrote: > > [...] > I agree that we need to check for the protocol availability of course, yet > it doesn't mean we should ditch this patch. > > Imagine (I say imagine, I do not know

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-29 Thread Lyude Paul
On Mon, 2018-05-28 at 09:11 +0200, Olivier Fourdan wrote: > Hey Luyde, > > On Fri, May 25, 2018 at 7:54 PM, Lyude Paul wrote: > > NAK, unfortunately this check isn't going to be enough, see: > > > > > > > > 2018-05-24 15:44:34 jadahl Lyude: you can also look at the globals > > sent > > >

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-28 Thread Pekka Paalanen
On Mon, 28 May 2018 09:59:43 +0200 Olivier Fourdan wrote: > Hi Pekka, > > On 28 May 2018 at 09:24, Pekka Paalanen wrote: > > > do not use strstr() for matching extensions strings. It does a > > sub-string match, which may not be what you want. What if there was an > > extension called "platfor

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-28 Thread Olivier Fourdan
Hi Pekka, On 28 May 2018 at 09:24, Pekka Paalanen wrote: > do not use strstr() for matching extensions strings. It does a > sub-string match, which may not be what you want. What if there was an > extension called "platform_gbm_unixmem" or such? > The substring match is what we want though, as

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-28 Thread Pekka Paalanen
On Fri, 25 May 2018 17:10:07 +0200 Olivier Fourdan wrote: > Check for "platform_gbm" in the avaiable EGL extensions, and enable > automatically EGL stream if not present. > > The command line options “-eglstream” is kept for compatibility to force > the use of the EGL streams backend. > > Sugge

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-28 Thread Olivier Fourdan
Hey Luyde, On Fri, May 25, 2018 at 7:54 PM, Lyude Paul wrote: > > NAK, unfortunately this check isn't going to be enough, see: > > 2018-05-24 15:44:34 jadahl Lyude: you can also look at the globals > sent > out by the compositor > 2018-05-24 15:44:52 Lyude jadahl: you mean the wl inte

Re: [PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-25 Thread Lyude Paul
NAK, unfortunately this check isn't going to be enough, see: 2018-05-24 15:44:34 jadahl Lyude: you can also look at the globals sent out by the compositor 2018-05-24 15:44:52 Lyude jadahl: you mean the wl interfaces 2018-05-24 15:45:30 jadahl yes 2018-05-24 15:46:22 -- ma

[PATCH xserver] Xwayland: Enable EGL backend automatically

2018-05-25 Thread Olivier Fourdan
Check for "platform_gbm" in the avaiable EGL extensions, and enable automatically EGL stream if not present. The command line options “-eglstream” is kept for compatibility to force the use of the EGL streams backend. Suggested-by: Ray Strode Signed-off-by: Olivier Fourdan --- Note: * This was