Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Adam Jackson
On Wed, 2018-03-21 at 16:37 +, Eric Engestrom wrote: > Hmm, forgot to reply, sorry about that: > I've had the patch locally for just about forever, so I don't remember > exactly, but I think I hit some issue with one of the callers and when > I looked at the implementations I noticed this. I

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Eric Engestrom
On Wednesday, 2018-03-21 11:24:50 -0400, Adam Jackson wrote: > On Wed, 2018-03-14 at 15:37 +, Emil Velikov wrote: > > On 13 March 2018 at 10:55, Eric Engestrom wrote: > > > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > > > pointer target type [-Wdiscarded-qualifi

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-21 Thread Adam Jackson
On Wed, 2018-03-14 at 15:37 +, Emil Velikov wrote: > On 13 March 2018 at 10:55, Eric Engestrom wrote: > > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > > pointer target type [-Wdiscarded-qualifiers] > > swap(pExaGC, pGC, funcs); > > ^ > > > > Sign

Re: [PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-14 Thread Emil Velikov
On 13 March 2018 at 10:55, Eric Engestrom wrote: > exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from > pointer target type [-Wdiscarded-qualifiers] > swap(pExaGC, pGC, funcs); > ^ > > Signed-off-by: Eric Engestrom > --- > exa/exa_priv.h | 2 +- > 1 file ch

[PATCH xserver] exa: promise not to touch the data when swapping pointers

2018-03-13 Thread Eric Engestrom
exa/exa.c:525:10: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] swap(pExaGC, pGC, funcs); ^ Signed-off-by: Eric Engestrom --- exa/exa_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exa/exa_priv.h b