Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hans de Goede writes: > If you want a real-world test point firefox to: > > https://lkml.org/lkml/2015/8/25/738 > > At least that is broken for me (skylake igpu + modesetting driver) > and this patch fixes it. Yes, Michel asked me to merge that patch a couple of days ago

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from exaComposite which ensure that the composite operation doesn't access outside of the

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Michel Dänzer writes: > [ Unknown signature status ] > On 30.05.2016 12:29, Keith Packard wrote: >> Michel Dänzer writes: >> >>> Let's take things one step at a time, get my patch in as is (which >>> brings us back to where we were before using copies

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

On 30.05.2016 12:29, Keith Packard wrote: > Michel Dänzer writes: > >> Let's take things one step at a time, get my patch in as is (which >> brings us back to where we were before using copies wrt correctness) and >> then yours on top? > > If that makes it easier for you to

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Michel Dänzer writes: > Let's take things one step at a time, get my patch in as is (which > brings us back to where we were before using copies wrt correctness) and > then yours on top? If that makes it easier for you to reason about, then it seems fine to me. -- -keith

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

On 28.05.2016 14:52, Keith Packard wrote: > Michel Dänzer writes: > >> You know the details better than I do, but my understanding is that the >> region can only be clipped to the destination in general, because >> accessing source pictures outside of their boundaries is

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 28-05-16 04:49, Michel Dänzer wrote: On 26.05.2016 21:55, Hans de Goede wrote: On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Michel Dänzer writes: > You know the details better than I do, but my understanding is that the > region can only be clipped to the destination in general, because > accessing source pictures outside of their boundaries is defined such > that it can change the contents of the

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

On 28.05.2016 05:29, Keith Packard wrote: > Michel Dänzer writes: >> From: Michel Dänzer >> >> Commit b64108fa ("glamor: Check for composite operations which are >> equivalent to copies") failed to copy conditions from exaComposite which >> ensure that

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

On 26.05.2016 21:55, Hans de Goede wrote: > On 26-05-16 12:04, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Commit b64108fa ("glamor: Check for composite operations which are >> equivalent to copies") failed to copy conditions from exaComposite which >> ensure that

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Michel Dänzer writes: > From: Michel Dänzer > > Commit b64108fa ("glamor: Check for composite operations which are > equivalent to copies") failed to copy conditions from exaComposite which > ensure that the composite operation doesn't access outside

Re: [PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hi, On 26-05-16 12:04, Michel Dänzer wrote: From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from exaComposite which ensure that the composite operation doesn't access outside of the

[PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

From: Michel Dänzer Commit b64108fa ("glamor: Check for composite operations which are equivalent to copies") failed to copy conditions from exaComposite which ensure that the composite operation doesn't access outside of the source picture. This fixes rendercheck