Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-12 Thread Manasi Navare
On Wed, Apr 12, 2017 at 11:00:18AM -0700, Eric Anholt wrote: > Martin Peres writes: > > > On 11/04/17 04:47, Eric Anholt wrote: > >> Martin Peres writes: > >> > >>> Despite all the careful planing of the kernel, a link may become > >>> insufficient to handle the currently-set mode. At this point

Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-12 Thread Eric Anholt
Martin Peres writes: > On 11/04/17 04:47, Eric Anholt wrote: >> Martin Peres writes: >> >>> Despite all the careful planing of the kernel, a link may become >>> insufficient to handle the currently-set mode. At this point, the >>> kernel should mark this particular configuration as being broken

Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-12 Thread Martin Peres
On 11/04/17 04:47, Eric Anholt wrote: Martin Peres writes: Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set mode. At this point, the kernel should mark this particular configuration as being broken and potentially prune the mode before s

Re: [PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-10 Thread Eric Anholt
Martin Peres writes: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode before setting the offending connector's

[PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-10 Thread Martin Peres
Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set mode. At this point, the kernel should mark this particular configuration as being broken and potentially prune the mode before setting the offending connector's link-status to BAD and send the

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-06 Thread Manasi Navare
On Sun, Apr 02, 2017 at 07:21:09PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > >> >> Manasi Navare writes: > >> >> > >

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Daniel Vetter
On Mon, Apr 3, 2017 at 8:25 AM, Manasi Navare wrote: >> So in that case you do need userspace to re-request the same mode at the >> same bpp? > > So yes because when userspace requests the same mode at same bpp, > kernel will still call intel_dp->mod_valid which validates the mode > against 18bpp

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Daniel Vetter
On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > Manasi Navare writes: > > > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: > >> >> Martin Peres writes: > >> >> > >>

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Manasi Navare
On Mon, Apr 03, 2017 at 09:19:35AM +0200, Daniel Vetter wrote: > On Mon, Apr 3, 2017 at 8:25 AM, Manasi Navare > wrote: > >> So in that case you do need userspace to re-request the same mode at the > >> same bpp? > > > > So yes because when userspace requests the same mode at same bpp, > > kernel

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-02 Thread Manasi Navare
On Sun, Apr 02, 2017 at 07:21:09PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > >> >> Manasi Navare writes: > >> >> > >

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-02 Thread Eric Anholt
Daniel Vetter writes: > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: >> Manasi Navare writes: >> >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: >> >> Manasi Navare writes: >> >> >> >> > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: >> >> >> Ma

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-31 Thread Eric Anholt
Manasi Navare writes: > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: >> Manasi Navare writes: >> >> > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: >> >> Martin Peres writes: >> >> >> >> > On 26/01/17 14:37, Martin Peres wrote: >> >> >> Despite all the careful p

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-31 Thread Manasi Navare
On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > Manasi Navare writes: > > > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: > >> Martin Peres writes: > >> > >> > On 26/01/17 14:37, Martin Peres wrote: > >> >> Despite all the careful planing of the kernel, a link may

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-31 Thread Eric Anholt
Manasi Navare writes: > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: >> Martin Peres writes: >> >> > On 26/01/17 14:37, Martin Peres wrote: >> >> Despite all the careful planing of the kernel, a link may become >> >> insufficient to handle the currently-set mode. At this point,

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-30 Thread Manasi Navare
On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: > Martin Peres writes: > > > On 26/01/17 14:37, Martin Peres wrote: > >> Despite all the careful planing of the kernel, a link may become > >> insufficient to handle the currently-set mode. At this point, the > >> kernel should mark thi

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-30 Thread Eric Anholt
Martin Peres writes: > On 26/01/17 14:37, Martin Peres wrote: >> Despite all the careful planing of the kernel, a link may become >> insufficient to handle the currently-set mode. At this point, the >> kernel should mark this particular configuration as being broken >> and potentially prune the m

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-27 Thread Martin Peres
On 26/01/17 14:37, Martin Peres wrote: Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set mode. At this point, the kernel should mark this particular configuration as being broken and potentially prune the mode before setting the offending co

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-28 Thread Daniel Vetter
On Thu, Feb 02, 2017 at 09:57:20AM -0800, Eric Anholt wrote: > Daniel Vetter writes: > > > On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > >> Jani Nikula writes: > >> > >> > On Tue, 31 Jan 2017, Eric Anholt wrote: > >> >> Martin Peres writes: > >> >> > >> >>> Despite all the ca

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-28 Thread Daniel Vetter
On Tue, Feb 28, 2017 at 04:07:02AM +, Navare, Manasi D wrote: > > On Fri, Feb 24, 2017 at 12:09:51PM -0800, Manasi Navare wrote: > > Hi Daniel, > > > > We have ACKs on the userspace design from both Adams and Eric. > > Is this enough to merge the kernel patches? > > > > I spoke to Eric brief

RE: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-27 Thread Navare, Manasi D
On Fri, Feb 24, 2017 at 12:09:51PM -0800, Manasi Navare wrote: > Hi Daniel, > > We have ACKs on the userspace design from both Adams and Eric. > Is this enough to merge the kernel patches? > > I spoke to Eric briefly about this and he gave me a verbal r-b as well. > He said the userspace patches

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-27 Thread Daniel Vetter
On Fri, Feb 24, 2017 at 12:09:51PM -0800, Manasi Navare wrote: > Hi Daniel, > > We have ACKs on the userspace design from both Adams and Eric. > Is this enough to merge the kernel patches? > > I spoke to Eric briefly about this and he gave me a verbal r-b as well. > He said the userspace patches

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-24 Thread Manasi Navare
Hi Daniel, We have ACKs on the userspace design from both Adams and Eric. Is this enough to merge the kernel patches? I spoke to Eric briefly about this and he gave me a verbal r-b as well. He said the userspace patches cant get merged unless DRM patches are merged. So what should be some of our

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-15 Thread Martin Peres
On 13/02/17 23:05, Eric Anholt wrote: I was just trying to provide review to get the kernel unstuck. The kernel should not be blocked until the patch gets lands (this obviously isn't the case with ioctls, which *don't* land in userspace until kernel does), you just need userspace published and g

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-13 Thread Manasi Navare
On Mon, Feb 13, 2017 at 01:05:17PM -0800, Eric Anholt wrote: > Martin Peres writes: > > > On 06/02/17 17:50, Martin Peres wrote: > >> On 03/02/17 10:04, Daniel Vetter wrote: > >>> On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: > On 01/02/17 22:05, Manasi Navare wrote: > >

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-13 Thread Eric Anholt
Martin Peres writes: > On 06/02/17 17:50, Martin Peres wrote: >> On 03/02/17 10:04, Daniel Vetter wrote: >>> On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: On 01/02/17 22:05, Manasi Navare wrote: > On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: >> Jani Ni

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-08 Thread Martin Peres
On 06/02/17 17:50, Martin Peres wrote: On 03/02/17 10:04, Daniel Vetter wrote: On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: On 01/02/17 22:05, Manasi Navare wrote: On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: Jani Nikula writes: On Tue, 31 Jan 2017, Eric An

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-06 Thread Martin Peres
On 03/02/17 10:04, Daniel Vetter wrote: On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: On 01/02/17 22:05, Manasi Navare wrote: On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: Jani Nikula writes: On Tue, 31 Jan 2017, Eric Anholt wrote: Martin Peres writes: De

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-05 Thread Daniel Vetter
On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: > On 01/02/17 22:05, Manasi Navare wrote: > > On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > > > Jani Nikula writes: > > > > > > > On Tue, 31 Jan 2017, Eric Anholt wrote: > > > > > Martin Peres writes: > > > > > > >

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-02 Thread Manasi Navare
On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: > On 01/02/17 22:05, Manasi Navare wrote: > >On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > >>Jani Nikula writes: > >> > >>>On Tue, 31 Jan 2017, Eric Anholt wrote: > Martin Peres writes: > > >Despite all t

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-02 Thread Daniel Vetter
On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > Jani Nikula writes: > > > On Tue, 31 Jan 2017, Eric Anholt wrote: > >> Martin Peres writes: > >> > >>> Despite all the careful planing of the kernel, a link may become > >>> insufficient to handle the currently-set mode. At this poi

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-02 Thread Martin Peres
On 01/02/17 22:05, Manasi Navare wrote: On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: Jani Nikula writes: On Tue, 31 Jan 2017, Eric Anholt wrote: Martin Peres writes: Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-02 Thread Eric Anholt
Daniel Vetter writes: > On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: >> Jani Nikula writes: >> >> > On Tue, 31 Jan 2017, Eric Anholt wrote: >> >> Martin Peres writes: >> >> >> >>> Despite all the careful planing of the kernel, a link may become >> >>> insufficient to handle th

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Jani Nikula
On Tue, 31 Jan 2017, Eric Anholt wrote: > Martin Peres writes: > >> Despite all the careful planing of the kernel, a link may become >> insufficient to handle the currently-set mode. At this point, the >> kernel should mark this particular configuration as being broken >> and potentially prune th

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Jani Nikula
On Tue, 31 Jan 2017, Manasi Navare wrote: > On Thu, Jan 26, 2017 at 06:21:20PM +0100, Daniel Vetter wrote: >> On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: >> > Despite all the careful planing of the kernel, a link may become >> > insufficient to handle the currently-set mode. At t

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > Jani Nikula writes: > > > On Tue, 31 Jan 2017, Eric Anholt wrote: > >> Martin Peres writes: > >> > >>> Despite all the careful planing of the kernel, a link may become > >>> insufficient to handle the currently-set mode. At this poi

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Eric Anholt
Jani Nikula writes: > On Tue, 31 Jan 2017, Eric Anholt wrote: >> Martin Peres writes: >> >>> Despite all the careful planing of the kernel, a link may become >>> insufficient to handle the currently-set mode. At this point, the >>> kernel should mark this particular configuration as being broke

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode be

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-01-31 Thread Eric Anholt
Martin Peres writes: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode before setting the offending connector's

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-01-31 Thread Manasi Navare
On Thu, Jan 26, 2017 at 06:21:20PM +0100, Daniel Vetter wrote: > On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > > Despite all the careful planing of the kernel, a link may become > > insufficient to handle the currently-set mode. At this point, the > > kernel should mark this parti

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-01-26 Thread Daniel Vetter
On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode be

[RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-01-26 Thread Martin Peres
Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set mode. At this point, the kernel should mark this particular configuration as being broken and potentially prune the mode before setting the offending connector's link-status to BAD and send the