Re: last call for 1.20 (was Re: [PATCH xserver] present: fix msc offset calculation in window mode)

Hi ajax, this one just sent out: "[PATCH xserver] modesetting: Remove ms_crtc_msc_to_kernel_msc().", should really make it into server 1.20, as it did bad things during my testing yesterday. Looking at the counterpart ms_kernel_msc_to_crtc_msc() in current modesetting-ddx makes me a bit nervous

last call for 1.20 (was Re: [PATCH xserver] present: fix msc offset calculation in window mode)

On Wed, 2018-05-02 at 14:58 -0400, Adam Jackson wrote: > I'll push out 1.20 shortly, I think things are about as well-baked as > they're going to get. We can always do stable releases if we need them. Roman has poked me on IRC asking for another day to look into this, so 1.20 won't be today.

Re: [PATCH xserver] present: fix msc offset calculation in window mode

On Fri, 2018-04-20 at 18:23 +0200, Olivier Fourdan wrote: > Hi, > > > On 20 April 2018 at 18:11, Michel Dänzer wrote: > > On 2018-04-20 05:10 PM, Roman Gilg wrote: > > > Instead of getting the current msc value from the window, which might be > > > different to old one

Re: [PATCH xserver] present: fix msc offset calculation in window mode

You are right that this would prevent possible future backends supporting window mode and with real crtcs to return consistent msc values. But this wouldn't work anyway currently since present_wnmd_get_ust_msc_ptr does not provide the crtc it expects to the backend, but only the window. I think

Re: [PATCH xserver] present: fix msc offset calculation in window mode

On Fri, Apr 20, 2018 at 6:23 PM, Olivier Fourdan wrote: > Unfortunately, contrary to my initial tests, the black window still occurs > randomly even with that patch applied. That's unfortunate. How severe is it? Is it just for a short period or longer? I believe you said on IRC

Re: [PATCH xserver] present: fix msc offset calculation in window mode

Hi, On 20 April 2018 at 18:11, Michel Dänzer wrote: > On 2018-04-20 05:10 PM, Roman Gilg wrote: > > Instead of getting the current msc value from the window, which might be > > different to old one directly take the last saved msc value saved in > > the window_priv struct.

Re: [PATCH xserver] present: fix msc offset calculation in window mode

On 2018-04-20 05:10 PM, Roman Gilg wrote: > Instead of getting the current msc value from the window, which might be > different to old one directly take the last saved msc value saved in > the window_priv struct. > > Signed-off-by: Roman Gilg > --- > present/present_wnmd.c |

[PATCH xserver] present: fix msc offset calculation in window mode

Instead of getting the current msc value from the window, which might be different to old one directly take the last saved msc value saved in the window_priv struct. Signed-off-by: Roman Gilg --- present/present_wnmd.c | 7 +-- 1 file changed, 1 insertion(+), 6