Re: [PATCH xserver] xkb: small clarification

2017-11-08 Thread Eric Engestrom
On Tuesday, 2017-11-07 18:37:11 +0100, Giuseppe Bilotta wrote: > --- > xkb/xkbUtils.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > On Tue, Nov 7, 2017 at 10:55 AM, Eric Engestrom wrote: > > > I think this patch is good, because it explicitly shows the NoSymbol > > value that i

[PATCH xserver] xkb: small clarification

2017-11-07 Thread Giuseppe Bilotta
--- xkb/xkbUtils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) On Tue, Nov 7, 2017 at 10:55 AM, Eric Engestrom wrote: > I think this patch is good, because it explicitly shows the NoSymbol > value that is tested later on. The implicit 0s are fine, but I think adding > a one-sentenc