If the logic op gets left enabled, it overrides the blending
operation, causing incorrect contents on the display.
v2: Disable only on non-ES2, but disable even for PictOpSrc
v3: Found another place this is needed in
glamor_composite_set_shader_blend
Signed-off-by: Keith Packard
---
glamor
Hi,
On 14-05-16 17:52, Keith Packard wrote:
If the logic op gets left enabled, it overrides the blending
operation, causing incorrect contents on the display.
v2: Disable only on non-ES2, but disable even for PictOpSrc
v3: Found another place this is needed in
glamor_composite_set_shader_b
Hans de Goede writes:
> Note I've not actually tested if these patches fix the issues at
> hand, I've only run my normal stuff and did not notice any
> regressions.
I'm surprised no-one else has noticed the problems with libreoffice;
random bits of GUI text rendered as black rectangles was prett
Hi Keith,
On 14 May 2016 at 16:52, Keith Packard wrote:
> diff --git a/glamor/glamor_render.c b/glamor/glamor_render.c
> index 65f7059..ea9abc7 100644
> --- a/glamor/glamor_render.c
> +++ b/glamor/glamor_render.c
> @@ -1075,10 +1075,14 @@
> glamor_composite_set_shader_blend(glamor_screen_privat
Emil Velikov writes:
> This hunk should be in 3/3, shouldn't it ?
Yup, thanks for the catch! Series re-pushed to my 'render-fixes' branch,
no change in the final version.
--
-keith
signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org
On 15.05.2016 19:48, Keith Packard wrote:
I'm surprised no-one else has noticed the problems with libreoffice;
random bits of GUI text rendered as black rectangles was pretty annoying
to me.
https://bugs.freedesktop.org/show_bug.cgi?id=63397#c24
--
Earthling Michel Dänzer|
Michel Dänzer writes:
> https://bugs.freedesktop.org/show_bug.cgi?id=63397#c24
Some day I'll think to look at bugzilla when I fix a bug :-)
I've added a comment and copy of the patch to that bug.
--
-keith
signature.asc
Description: PGP signature
On 17.05.2016 06:05, Keith Packard wrote:
> Michel Dänzer writes:
>
>> https://bugs.freedesktop.org/show_bug.cgi?id=63397#c24
>
> Some day I'll think to look at bugzilla when I fix a bug :-)
>
> I've added a comment and copy of the patch to that bug.
The glamor_set_composite_texture related ch
Michel Dänzer writes:
> The glamor_set_composite_texture related change in this patch needs to
> be moved to patch 3, or this patch fails to build. With that fixed,
> patches 1 & 2 are
That was also mentioned by Emil Velikov and was fixed in [v4] 1/3 and [v2] 3/3
> Reviewed-by: Michel Dänzer
>
