Re: [PATCH xserver 1/4] modesetting: Fix potential buffer overflow

2017-10-30 Thread Adam Jackson
On Mon, 2017-10-30 at 09:51 +, Eric Engestrom wrote: > On Friday, 2017-10-27 16:11:53 +0200, Daniel Martin wrote: > > If one misconfigures a ZaphodHeads value (more than 20 characters > > without a delimiter), we get an overflow of our buffer. > > Use xstrtokenize() instead of writing/fixing ou

Re: [PATCH xserver 1/4] modesetting: Fix potential buffer overflow

2017-10-30 Thread Eric Engestrom
On Friday, 2017-10-27 16:11:53 +0200, Daniel Martin wrote: > If one misconfigures a ZaphodHeads value (more than 20 characters > without a delimiter), we get an overflow of our buffer. > Use xstrtokenize() instead of writing/fixing our own tokenizer. > > Signed-off-by: Daniel Martin Patches 1-3

[PATCH xserver 1/4] modesetting: Fix potential buffer overflow

2017-10-27 Thread Daniel Martin
If one misconfigures a ZaphodHeads value (more than 20 characters without a delimiter), we get an overflow of our buffer. Use xstrtokenize() instead of writing/fixing our own tokenizer. Signed-off-by: Daniel Martin --- hw/xfree86/drivers/modesetting/drmmode_display.c | 38 ---