Re: [PATCH xserver 2/3] glx: Inline some reply swapping code

2017-08-18 Thread Keith Packard
Adam Jackson writes: > Consistency and cleanliness? They're the only out-of-lined reply swap > functions which puts them solidly in the minority (seven out of GLX's > 32ish replies), and glxserver.h is currently kind of a misc-and-other > header that I was trying to give some focus. Ok, seems fi

Re: [PATCH xserver 2/3] glx: Inline some reply swapping code

2017-08-18 Thread Adam Jackson
On Wed, 2017-08-16 at 15:00 -0700, Keith Packard wrote: > Adam Jackson writes: > > > Signed-off-by: Adam Jackson > > Why? I can see removing the WriteToClient calls from the functions, but > any particular reason to inline them? Consistency and cleanliness? They're the only out-of-lined reply

[PATCH xserver 2/3] glx: Inline some reply swapping code

2017-08-16 Thread Adam Jackson
Signed-off-by: Adam Jackson --- glx/glxcmds.c | 68 ++- glx/glxcmdsswap.c | 103 -- glx/glxserver.h | 22 3 files changed, 52 insertions(+), 141 deletions(-) diff --git a/glx/glxcmds.c b/glx/