Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-10 Thread Alex Goins
On Fri, 10 Nov 2017, Michel Dänzer wrote: > On 09/11/17 08:09 PM, Alex Goins wrote: > >> On 09/11/17 02:34 AM, Alex Goins wrote: > >>> On Wed, 8 Nov 2017, Michel Dänzer wrote: > > > >> I'm asking this to avoid ending up in a similar situation as with the > >> PRIME synchronization functionality,

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-10 Thread Michel Dänzer
On 09/11/17 08:09 PM, Alex Goins wrote: >> On 09/11/17 02:34 AM, Alex Goins wrote: >>> On Wed, 8 Nov 2017, Michel Dänzer wrote: > >> I'm asking this to avoid ending up in a similar situation as with the >> PRIME synchronization functionality, where it seems like the modesetting >> driver still can

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-09 Thread Alex Goins
> On 09/11/17 02:34 AM, Alex Goins wrote: > > On Wed, 8 Nov 2017, Michel Dänzer wrote: > I'm asking this to avoid ending up in a similar situation as with the > PRIME synchronization functionality, where it seems like the modesetting > driver still can't use it with itself as the peer. The modese

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-09 Thread Michel Dänzer
On 09/11/17 03:06 PM, Hans de Goede wrote: > On 09-11-17 02:34, Alex Goins wrote: >> On Wed, 8 Nov 2017, Hans de Goede wrote: >> and that would be preferable to using the server's software cursor (due to the fact that it's unsynchronzied by OpenGL rendering to the root window, it can

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-09 Thread Hans de Goede
Hi, On 09-11-17 02:34, Alex Goins wrote: Thanks both for the quick feedback. Replies inline. On Wed, 8 Nov 2017, Hans de Goede wrote: https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies that xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such. I'm no

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-09 Thread Michel Dänzer
On 09/11/17 02:34 AM, Alex Goins wrote: > On Wed, 8 Nov 2017, Michel Dänzer wrote: > >>> Change 7b634067 added HW cursor support for PRIME by removing the >>> pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite >>> cursor functions set/check the cursor both on master and sl

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-08 Thread Alex Goins
Thanks both for the quick feedback. Replies inline. On Wed, 8 Nov 2017, Hans de Goede wrote: > > https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies > > that > > xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such. > > I'm not sure if exporting this is a

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-08 Thread Michel Dänzer
On 08/11/17 05:15 AM, Alex Goins wrote: > Change 7b634067 added HW cursor support for PRIME by removing the > pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite > cursor functions set/check the cursor both on master and slave. > > However, before this change, drivers that

Re: [PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-08 Thread Hans de Goede
Hi, On 08-11-17 05:15, Alex Goins wrote: Change 7b634067 added HW cursor support for PRIME by removing the pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite cursor functions set/check the cursor both on master and slave. However, before this change, drivers that did no

[PATCH xserver 3/3] ramdac: Handle master and slave cursors independently

2017-11-07 Thread Alex Goins
Change 7b634067 added HW cursor support for PRIME by removing the pixmap_dirty_list check from xf86CursorSetCursor() and making the requisite cursor functions set/check the cursor both on master and slave. However, before this change, drivers that did not make use of pixmap_dirty_list to implement