On 2017-05-10 3:26 PM, Adam Jackson wrote:
> On Wed, 2017-05-10 at 10:11 +0100, Eric Engestrom wrote:
>> On Tuesday, 2017-05-09 19:39:47 -0400, Peter Harris wrote:
>>> +#if defined HAVE_LIBBSD && defined HAVE_REALLOCARRAY
>>
>> nit: most of the codebase uses `defined(FOO)` (313 vs 5 occurences)
>>
On Wed, 2017-05-10 at 10:11 +0100, Eric Engestrom wrote:
> On Tuesday, 2017-05-09 19:39:47 -0400, Peter Harris wrote:
> > +#if defined HAVE_LIBBSD && defined HAVE_REALLOCARRAY
>
> nit: most of the codebase uses `defined(FOO)` (313 vs 5 occurences)
> quick sed to fix it: s/defined\s+(\w+)/defined\(
On Tuesday, 2017-05-09 19:39:47 -0400, Peter Harris wrote:
> If we're linking with libbsd anyway, we might as well use the functions
> it provides instead of compiling our replacements.
>
> Signed-off-by: Peter Harris
> ---
> include/meson.build | 6 +++---
> include/os.h| 6 ++
> 2
Peter Harris writes:
> If we're linking with libbsd anyway, we might as well use the functions
> it provides instead of compiling our replacements.
>
> Signed-off-by: Peter Harris
This series is:
Reviewed-by: Eric Anholt
Let me know if you would like me to push them.
signature.asc
Descript
If we're linking with libbsd anyway, we might as well use the functions
it provides instead of compiling our replacements.
Signed-off-by: Peter Harris
---
include/meson.build | 6 +++---
include/os.h| 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/include/meson.
