Re: [PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-06 Thread Adam Jackson
On Wed, 2016-01-06 at 07:00 +0100, Thomas Klausner wrote: > Hello Adam! > > > If it's not too much trouble, please use git-send-email --in-reply-to > > for followup patches like this. > > Thanks, I didn't know about this. I'll use it in the future. And > thanks for the macro fix, it looks good to

Re: [PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-05 Thread Thomas Klausner
Hello Adam! > If it's not too much trouble, please use git-send-email --in-reply-to > for followup patches like this. Thanks, I didn't know about this. I'll use it in the future. And thanks for the macro fix, it looks good to me. Thomas On Tue, Jan 05, 2016 at 12:51:41PM -0500, Adam Jackson wro

[PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-05 Thread Adam Jackson
From: Thomas Klausner v2: Move initializing pos into the first clause of the for statement. We have to keep this macro equivalent to a plain for statement from the user's perspective, otherwise callers need to {} things to keep control flow correct. [ajax] Signed-off-by: Thomas Klausner Acked-b