Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-30 Thread Jonas Ådahl
On Wed, Sep 30, 2015 at 07:43:50AM -0700, Keith Packard wrote: > Jonas Ådahl writes: > > > Yes, otherwise we'd crash in miPointerUpdateSprite when trying to access > > pCursor->bits. > > pSpriteCursor, not pCursor. Ugh, poking in mipointers struct directly, ok. I'll have to expose the MIPOINTER

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-30 Thread Keith Packard
Jonas Ådahl writes: > Yes, otherwise we'd crash in miPointerUpdateSprite when trying to access > pCursor->bits. pSpriteCursor, not pCursor. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: h

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-29 Thread Jonas Ådahl
On Tue, Sep 29, 2015 at 10:04:40PM -0700, Keith Packard wrote: > Jonas Ådahl writes: > > > On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote: > >> Jonas Ådahl writes: > >> > >> > As mentioned, a different approach would be to work-around the issue in > >> > xwayland, but I consider

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-29 Thread Keith Packard
Jonas Ådahl writes: > On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote: >> Jonas Ådahl writes: >> >> > As mentioned, a different approach would be to work-around the issue in >> > xwayland, but I consider such a solution more hacky than this. Please let >> > me know what you think.

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-29 Thread Jonas Ådahl
On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote: > Jonas Ådahl writes: > > > As mentioned, a different approach would be to work-around the issue in > > xwayland, but I consider such a solution more hacky than this. Please let > > me know what you think. > > All you need do in xway

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-29 Thread Keith Packard
Jonas Ådahl writes: > As mentioned, a different approach would be to work-around the issue in > xwayland, but I consider such a solution more hacky than this. Please let > me know what you think. All you need do in xwayland is smash pSpriteCursor to some other value, like ((CursorPtr) (intptr_t)

[PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

2015-09-28 Thread Jonas Ådahl
In Wayland, a client (in this case XWayland) should set the cursor surface when it receives pointer focus. Not doing this will leave the curser at whatever it was previously. When running on XWayland, the X server will not be the entity that controls what actual pointer cursor is displayed, and it