Re: [PULL] hw/xwin fixes + a warning fix

2012-01-27 Thread Jon TURNEY
On 27/01/2012 04:22, Keith Packard wrote: On Fri, 27 Jan 2012 10:28:40 +1000, Peter Hutterer wrote: Jon confirmed on IRC that just removing miSetPointerPosition() fixes it anyways, so let's do that. Makes a lot more sense to me anyways... Thanks for spotting this. I have amended that

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-27 Thread Keith Packard
On Fri, 27 Jan 2012 12:02:21 +, Jon TURNEY jon.tur...@dronecode.org.uk wrote: I have amended that patch as suggested by Peter and re-pushed my branch. Merged. 02775ef..8e78bbb master - master -- keith.pack...@intel.com pgpPbFA5fEqZt.pgp Description: PGP signature

[PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Jon TURNEY
Hi Keith, Please consider pulling into master. Thanks. The following changes since commit 02775efb8930291cc62fc84086c97da75b912a55: int10: Fix unmapping of the BIOS scratch area (2012-01-25 09:26:23 -0800) are available in the git repository at:

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Thu, 26 Jan 2012 16:13:59 +, Jon TURNEY jon.tur...@dronecode.org.uk wrote: hw/xwin: Fix winEnqueueMotion() for change in miPointerSetPosition() This looks like it's missing x = dx; y = dy; Without that, you'll miss any changes to position made by

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, This looks like it's missing x = dx; y = dy; With this in I get no mouse events (on the left monitor) when the main display is not leftmost with multiple monitors. The casting is probably messing up negative x's on Windows? As in the [PULL] I can't detect any position errors.

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Thu, 26 Jan 2012 19:27:42 -, Colin Harrison colin.harri...@virgin.net wrote: This looks like it's missing x = dx; y = dy; With this in I get no mouse events (on the left monitor) when the main display is not leftmost with multiple monitors. I don't understand how

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Looking into it further the code at the end of miPointerSetPosition() maybe the cause of this... /* In the event we actually change screen or we get confined, we just * drop the float component on the floor * FIXME: only drop remainder for ConstrainCursorHarder, not for screen

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Daniel Stone
Hi, On 27 January 2012 10:22, Colin Harrison colin.harri...@virgin.net wrote: If I revert those traps and then call the function... void winEnqueueMotion(int x, int y) {  int valuators[2];  ValuatorMask mask;  double dx = (double)x;  double dy = (double)y;  

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Daniel wrote: Why are you actually calling miPointerSetPosition at all? Someone had to be daft enough to use it. As in if it isn't defined static then it must be useful And if it is then I want to access it anyway :) It's late...more coffee is required to wash away the dust! Thanks,

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Peter Hutterer
On Thu, Jan 26, 2012 at 01:10:53PM -0800, Keith Packard wrote: On Thu, 26 Jan 2012 19:27:42 -, Colin Harrison colin.harri...@virgin.net wrote: This looks like it's missing x = dx; y = dy; With this in I get no mouse events (on the left monitor) when the main

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Fri, 27 Jan 2012 10:28:40 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: Jon confirmed on IRC that just removing miSetPointerPosition() fixes it anyways, so let's do that. Makes a lot more sense to me anyways... -- keith.pack...@intel.com pgpX9OtWdnRR5.pgp Description: PGP