Re: [Patches] Small cleanups and fixes to sessreg

2011-06-27 Thread Ed Schouten
Ugh, It seems there are more things that can be improved here. Please see the attached set of patches. The previous email can be ignored. Greetings, -- Ed Schouten e...@80386.nl WWW: http://80386.nl/ From 42e3ce68f68471ff714167b0e2860c36dda82efd Mon Sep 17 00:00:00 2001 From: Ed Schouten

Re: [Patches] Small cleanups and fixes to sessreg

2011-06-26 Thread Alan Coopersmith
On 06/26/11 05:14 AM, Ed Schouten wrote: Ugh, It seems there are more things that can be improved here. Please see the attached set of patches. The previous email can be ignored. There's always more things that can be improved in our source code. These looked good to me, and built cleanly on

Re: [Patches] Small cleanups and fixes to sessreg

2011-06-25 Thread Ed Schouten
* Alan Coopersmith alan.coopersm...@oracle.com, 20110625 06:58: Looks good to me - pushed to git master. Thanks! Unfortunately, I seem to have introduced a small bug. I tried building the code on FreeBSD 9 and Linux, but I forgot to test it on FreeBSD 8, where we have to include sys/types.h

[Patches] Small cleanups and fixes to sessreg

2011-06-24 Thread Ed Schouten
Hi all, I've attached five patches for sessreg: [PATCH 1/5] Correct whitespace and indentation. [PATCH 2/5] Fix typo in function name check. [PATCH 3/5] Only split off /dev/ instead trimming to last /. [PATCH 4/5] Use Autoconf to check for utmp field existence.

Re: [Patches] Small cleanups and fixes to sessreg

2011-06-24 Thread Alan Coopersmith
On 06/24/11 07:04 AM, Ed Schouten wrote: Hi all, I've attached five patches for sessreg: [PATCH 1/5] Correct whitespace and indentation. [PATCH 2/5] Fix typo in function name check. [PATCH 3/5] Only split off /dev/ instead trimming to last /. [PATCH 4/5] Use