Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed)

2010-03-24 Thread Soeren Sandmann
Matthias Hopf writes: > On Mar 24, 10 19:19:15 +0100, Soeren Sandmann wrote: > > > However, what happens if the code would have been compiled with -NDEBUG? > > > Is the code path stable with empty regions? If it is, it can be argued > > > that the patch is not necessary, but it could also be argu

Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed)

2010-03-24 Thread Matthias Hopf
On Mar 24, 10 19:19:15 +0100, Soeren Sandmann wrote: > > However, what happens if the code would have been compiled with -NDEBUG? > > Is the code path stable with empty regions? If it is, it can be argued > > that the patch is not necessary, but it could also be argued that the > > assert() shouldn

Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed)

2010-03-24 Thread Soeren Sandmann
Matthias Hopf writes: > > This patch in particular, I don't think shold ship with no testing at > > all. So please revert it, and we can consider it again for 0.19.x. > > I'm fine with that if you consider it problematic. Given that the > situation it changes should actually not occur at all, I

Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed)

2010-03-24 Thread Matthias Hopf
On Mar 24, 10 18:28:07 +0100, Soeren Sandmann wrote: > Please note that while pixman is not as strict as the X server in who > can push to the repository, it is not a complete free-for-all. > Committing small, obvious patches that fixes typos or oversights is > fine, but don't commit non-obvious st

Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed)

2010-03-24 Thread Soeren Sandmann
Hi Matthias, > The following patch fixes Novell bug 568811: > VNC Installation aborts right in the middle due to an assertion in > Xvnc/libpixman > > The bug seems occur only on *very* special occasions (in this case, only > in SLES, but *not* in SLED, which is based on the same code basis...)

Re: [Pixman] [PATCH] Fix server crash in pixman (to be discussed) (fwd)

2010-03-24 Thread Matthias Hopf
Grrr. Still wrong mailing list. Matthias -- Matthias Hopf ____ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ m...@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de --- Begin Message --- On Mar 24, 10 13:25:13 +0200, Jonathan