Re: [RFC/PATCH] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-06-16 Thread Dan Nicholson
On Tue, Jun 15, 2010 at 5:12 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Input driver messages are only standardised by convention, with the drivers prefixing the device name to most messages. This makes it rather hard to grep on evdev for example when looking for the evdev ouput. This

Re: [RFC/PATCH] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-06-16 Thread Tiago Vignatti
On Wed, Jun 16, 2010 at 02:37:48PM +0200, ext Dan Nicholson wrote: Since this definition is in xf86Xinput.h, xf86Xinput.h is part of the SDK, and these functions have to do with input devices, does it make sense to put the declarations there and the code in xf86Xinput.c? Or keep the code in

[RFC/PATCH] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-06-15 Thread Peter Hutterer
Input driver messages are only standardised by convention, with the drivers prefixing the device name to most messages. This makes it rather hard to grep on evdev for example when looking for the evdev ouput. This patch adds three new logging functions, modeled after xf86DrvMsg(), the logging

Re: [RFC/PATCH] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-06-15 Thread Alan Coopersmith
+tmpFormat = malloc(strlen(format)+ strlen(dev-drv-driverName) + strlen(dev-name) + 5); +if (!tmpFormat) +return; + +sprintf(tmpFormat, %s: %s: %s, dev-drv-driverName, dev-name, format); Xprintf() ? (Aka our portable version of the not-yet-universal asprintf().) --

Re: [RFC/PATCH] xfree86: add xf86IDrvMsg and friends for input driver logging.

2010-06-15 Thread Peter Hutterer
On Tue, Jun 15, 2010 at 05:32:55PM -0700, Alan Coopersmith wrote: +tmpFormat = malloc(strlen(format)+ strlen(dev-drv-driverName) + strlen(dev-name) + 5); +if (!tmpFormat) +return; + +sprintf(tmpFormat, %s: %s: %s, dev-drv-driverName, dev-name, format);