Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-07 Thread Julien Cristau
On Tue, Oct 6, 2009 at 14:07:33 -0700, Ping wrote: Does xserver have mechanism to create multiple X input devices in a single instance now? As far as I know, you can check that you're being hotplugged via udev and that the Type option is not set, set up the needed additional devices with the

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-07 Thread Ping
On Wed, Oct 7, 2009 at 4:38 AM, Julien Cristau jcris...@debian.org wrote: On Tue, Oct 6, 2009 at 14:07:33 -0700, Ping wrote: Does xserver have mechanism to create multiple X input devices in a single instance now? As far as I know, you can check that you're being hotplugged via udev

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-07 Thread Peter Hutterer
On Wed, Oct 07, 2009 at 06:58:57AM -0700, Ping wrote: On Wed, Oct 7, 2009 at 4:38 AM, Julien Cristau jcris...@debian.org wrote: On Tue, Oct 6, 2009 at 14:07:33 -0700, Ping wrote: Does xserver have mechanism to create multiple X input devices in a single instance now? As far as

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-07 Thread Ping
Ok, I 'll take this opportunity to prove xf86-input-wacom is responsive and give you all a break. I will also take care of both hal/libudev and xorg.conf. The fix will be ready for xorg 1.8 if my driver can be included. Fair? Ping On Wed, Oct 7, 2009 at 7:14 PM, Daniel Stone

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-07 Thread Daniel Stone
Hi, On Wed, Oct 07, 2009 at 08:37:31PM -0700, Ping wrote: Ok, I 'll take this opportunity to prove xf86-input-wacom is responsive and give you all a break. I will also take care of both hal/libudev and xorg.conf. The fix will be ready for xorg 1.8 if my driver can be included. Fair? More

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Julien Cristau
On Mon, Oct 5, 2009 at 14:13:39 -0400, Adam Jackson wrote: On Tue, 2009-09-29 at 23:54 +0200, Julien Cristau wrote: - what's the recommended way to avoid races between the 'enumerate' and 'monitor' parts? I suspect the answer is turn on monitor, then enumerate, then read plug events

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Julien Cristau
On Thu, Oct 1, 2009 at 16:40:04 -0700, Dan Nicholson wrote: On Thu, Oct 1, 2009 at 7:54 AM, Julien Cristau jcris...@debian.org wrote: I'm happy to remove the x11_options stuff from config/udev.c if there's a way to set options for hotplugged devices from the ddx.  Does driver selection

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Adam Jackson
On Tue, 2009-10-06 at 13:22 +0200, Julien Cristau wrote: On Mon, Oct 5, 2009 at 14:13:39 -0400, Adam Jackson wrote: I don't think the timer should be needed for libudev. All udev_monitor_new_from_netlink() does aside from malloc() is open a netlink socket. If that fails you have a

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Daniel Stone
On Tue, Oct 06, 2009 at 11:26:37AM -0400, Adam Jackson wrote: On Tue, 2009-10-06 at 13:22 +0200, Julien Cristau wrote: On Mon, Oct 5, 2009 at 14:13:39 -0400, Adam Jackson wrote: I don't think the timer should be needed for libudev. All udev_monitor_new_from_netlink() does aside from

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Dan Nicholson
On Tue, Oct 6, 2009 at 4:32 AM, Julien Cristau jcris...@debian.org wrote: On Thu, Oct  1, 2009 at 16:40:04 -0700, Dan Nicholson wrote: On Thu, Oct 1, 2009 at 7:54 AM, Julien Cristau jcris...@debian.org wrote: I'm happy to remove the x11_options stuff from config/udev.c if there's a way to

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Matthew Garrett
I think that this will currently break wacom. Wacom is set up to provide one input device per input mechanism - so typically we may have pen, stylus and eraser. The driver insists on each of these being declared as separate instances, so in hal we have a callout for wacoms that generates extra

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-06 Thread Ping
Thank you, Matthew, for picking up this topic for Wacom. Please see my comments in line. Ping On Tue, Oct 6, 2009 at 11:25 AM, Matthew Garrett mj...@srcf.ucam.orgwrote: I think that this will currently break wacom. Wacom is set up to provide one input device per input mechanism - so typically

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-05 Thread Adam Jackson
On Tue, 2009-09-29 at 23:54 +0200, Julien Cristau wrote: - what's the recommended way to avoid races between the 'enumerate' and 'monitor' parts? I suspect the answer is turn on monitor, then enumerate, then read plug events from the monitor, and no-op adding a device you've already added.

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-10-01 Thread Dan Nicholson
On Thu, Oct 1, 2009 at 7:54 AM, Julien Cristau jcris...@debian.org wrote: On Wed, Sep 30, 2009 at 11:34:52 -0700, Dan Nicholson wrote: One thing I was hoping was not to have the options input from the device configuration again. Having people migrate their setups to hal was not fun, and now

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Rémi Cardona
Hi Julien, Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit : If libudev is found, we use that for hotplug and disable the hal and dbus backends. Why disable dbus? I see udev being in conflict with HAL, but not with the dbus code. Not that it matters much, I don't think any

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Daniel Stone
On Wed, Sep 30, 2009 at 08:47:27AM +0200, Rémi Cardona wrote: Hi Julien, Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit : If libudev is found, we use that for hotplug and disable the hal and dbus backends. Why disable dbus? I see udev being in conflict with HAL, but

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Julien Cristau
On Wed, Sep 30, 2009 at 08:47:27 +0200, Rémi Cardona wrote: Hi Julien, Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit : If libudev is found, we use that for hotplug and disable the hal and dbus backends. Why disable dbus? I see udev being in conflict with HAL, but not

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Peter Hutterer
On Wed, Sep 30, 2009 at 10:17:47AM +0200, Julien Cristau wrote: On Wed, Sep 30, 2009 at 08:47:27 +0200, Rémi Cardona wrote: Hi Julien, Le mardi 29 septembre 2009 à 23:54 +0200, Julien Cristau a écrit : If libudev is found, we use that for hotplug and disable the hal and dbus

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Simon Thum
Julien Cristau wrote: - what's the recommended way to avoid races between the 'enumerate' and 'monitor' parts? I can't tell you that but since it's a common race: Why not listen before enumerate and let both feed the same ts queue? Just as an inspiration, I don't know udev. Cheers, Simon

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Dan Nicholson
On Wed, Sep 30, 2009 at 7:42 AM, Daniel Stone dan...@fooishbar.org wrote: On Wed, Sep 30, 2009 at 10:17:47AM +0200, Julien Cristau wrote: On Wed, Sep 30, 2009 at 08:47:27 +0200, Rémi Cardona wrote: I think the xkb HAL keys were deprecated in favor of x11_options.Xkb*, let's at least drop the

Re: [RFC PATCH] Initial libudev input-hotplug support

2009-09-30 Thread Daniel Stone
Hi, On Wed, Sep 30, 2009 at 11:34:52AM -0700, Dan Nicholson wrote: One thing I was hoping was not to have the options input from the device configuration again. Having people migrate their setups to hal was not fun, and now they'll have to do it again to udev rules files. I have a couple

[RFC PATCH] Initial libudev input-hotplug support

2009-09-29 Thread Julien Cristau
If libudev is found, we use that for hotplug and disable the hal and dbus backends. We look for event devices with an x11_driver property. XKB configuration happens using xkb.{rules,model,layout,variant,options} properties, and arbitrary options can be set with x11_options.foo (this is similar to