Re: [RFC PATCH] sync: Fix logic error from b55bf248581dc66321b24b29f199f6dc8d02db1b

2012-08-06 Thread Keith Packard
Adam Jackson writes: > So I'd like to get this sorted out. I'm gonna trust Peter on this one and hope he's right. Xsync is not easy to understand... Merged. 454d0e3..4a6f42d master -> master -- keith.pack...@intel.com pgp1Zs7aQ8Xwo.pgp Description: PGP signature

Re: [RFC PATCH] sync: Fix logic error from b55bf248581dc66321b24b29f199f6dc8d02db1b

2012-07-24 Thread Peter Hutterer
On Mon, Jul 23, 2012 at 04:34:28PM -0400, Adam Jackson wrote: > That commit adds two hunks, and I _think_ they're backwards. It adds > code to modify bracket_greater on NegativeTransition triggers, and > bracket_less on PositiveTransition triggers. That breaks symmetry with > the surrounding code

[RFC PATCH] sync: Fix logic error from b55bf248581dc66321b24b29f199f6dc8d02db1b

2012-07-23 Thread Adam Jackson
That commit adds two hunks, and I _think_ they're backwards. It adds code to modify bracket_greater on NegativeTransition triggers, and bracket_less on PositiveTransition triggers. That breaks symmetry with the surrounding code; the code as of this commit could probably be simplified further. I