Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2017-03-23 Thread Michel Dänzer
On 23/03/17 07:59 PM, Hans de Goede wrote: > On 20-09-16 03:58, Michel Dänzer wrote: >> On 17/09/16 07:00 PM, Hans De Goede wrote: >>> Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma >>> code") >>> dropped the providing of a pScrn->ChangeGamma callback from the >>> xf86RandR12

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2017-03-23 Thread Hans de Goede
Hi, On 20-09-16 03:58, Michel Dänzer wrote: On 17/09/16 07:00 PM, Hans De Goede wrote: Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGamma NULL in most cases. Th

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-27 Thread Hans de Goede
Hi, On 25-09-16 09:51, Michel Dänzer wrote: On 23/09/16 07:48 PM, Hans de Goede wrote: On 09/23/2016 11:13 AM, Michel Dänzer wrote: On 23/09/16 03:46 PM, Hans de Goede wrote: Since this is a fallback which ideally should never get used (all drivers should call xf86HandleColormaps) I believe

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-25 Thread Michel Dänzer
On 23/09/16 07:48 PM, Hans de Goede wrote: > On 09/23/2016 11:13 AM, Michel Dänzer wrote: >> On 23/09/16 03:46 PM, Hans de Goede wrote: >>> >>> Since this is a fallback which ideally should never get used (all >>> drivers should call xf86HandleColormaps) I believe it is not worth >>> the time to im

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-23 Thread Hans de Goede
Hi, On 09/23/2016 11:13 AM, Michel Dänzer wrote: On 23/09/16 03:46 PM, Hans de Goede wrote: On 09/20/2016 04:58 AM, Michel Dänzer wrote: If there are other drivers which can't call xf86HandleColormaps for some reason, a better solution would be to combine the per-screen gamma set via pScrn->C

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-23 Thread Michel Dänzer
On 23/09/16 03:46 PM, Hans de Goede wrote: > On 09/20/2016 04:58 AM, Michel Dänzer wrote: > >> If there are other drivers which can't call xf86HandleColormaps for some >> reason, a better solution would be to combine the per-screen gamma set >> via pScrn->ChangeGamma with the per-CRTC gamma set vi

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-22 Thread Hans de Goede
Hi, On 09/20/2016 04:58 AM, Michel Dänzer wrote: On 17/09/16 07:00 PM, Hans De Goede wrote: Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGamma NULL in most cases

Re: [xserver, 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-19 Thread Michel Dänzer
On 17/09/16 07:00 PM, Hans De Goede wrote: > Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") > dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 > code. Leaving pScrn->ChangeGamma NULL in most cases. > > This triggers the BadImplementation erro

Re: [PATCH xserver 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-19 Thread Alex Deucher
On Mon, Sep 19, 2016 at 11:31 AM, Alex Deucher wrote: > On Sat, Sep 17, 2016 at 6:00 AM, Hans de Goede wrote: >> Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") >> dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 >> code. Leaving pScrn->Chang

Re: [PATCH xserver 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-19 Thread Alex Deucher
On Sat, Sep 17, 2016 at 6:00 AM, Hans de Goede wrote: > Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") > dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 > code. Leaving pScrn->ChangeGamma NULL in most cases. > > This triggers the BadImplemen

[PATCH xserver 2/2] xf86RandR12: Fix XF86VidModeSetGamma triggering a BadImplementation error

2016-09-17 Thread Hans de Goede
Commit b4e46c0444bb ("xfree86: Hook up colormaps and RandR 1.2 gamma code") dropped the providing of a pScrn->ChangeGamma callback from the xf86RandR12 code. Leaving pScrn->ChangeGamma NULL in most cases. This triggers the BadImplementation error in xf86ChangeGamma() : if (pScrn->ChangeGamma)