Re: GetScratchPixmapHeader / FreeScratchPixmapHeader

2022-12-21 Thread Jeremy Huddleston Sequoia
Alrighty, then here it is: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1032?commit_id=5781ffcf5f3c918a97fe590ddb605fe0fefdb6ca Thanks, Jeremy > On Dec 21, 2022, at 13:24, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> Is there any real benefit to maintai

Re: GetScratchPixmapHeader / FreeScratchPixmapHeader

2022-12-21 Thread Keith Packard
Jeremy Huddleston Sequoia writes: > Is there any real benefit to maintaining this released pixmap for > future re-use on modern hardware? It seems like it's a bunch of code > complexity without much benefit. I'm happy to nuke it completely > unless there are objections... Seems reasonable -- i

GetScratchPixmapHeader / FreeScratchPixmapHeader

2022-12-21 Thread Jeremy Huddleston Sequoia
In triaging some issues related to pixmaps in XQuartz / rootlesss these past few weeks, I found it useful to just disable recycling the scratch pixmap header. Specifically, in my debug build, GetScratchPixmapHeader() just does CreatePixmap + ModifyPixmapHeader and FreeScratchPixmapHeader() just