Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-21 Thread Dmitry Torokhov
On Sat, Apr 21, 2012 at 10:16:40AM +1000, Benjamin Herrenschmidt wrote: On Fri, 2012-04-20 at 10:01 -0700, Dmitry Torokhov wrote: It looks we lost a condition in synaptics_set_advanced_gesture_mode(). It used to be: if (!(SYN_CAP_ADV_GESTURE(priv-ext_cap_0c) ||

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-21 Thread Daniel Drake
On Fri, Apr 20, 2012 at 6:16 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: It looks we lost a condition in synaptics_set_advanced_gesture_mode(). It used to be:       if (!(SYN_CAP_ADV_GESTURE(priv-ext_cap_0c) ||                       SYN_CAP_IMAGE_SENSOR(priv-ext_cap_0c)))    

Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Benjamin Herrenschmidt
Hi folks ! So Peter and I have been discussing a problem I observed on my brand new ThinkPad X220 and it's multitouch clickpad. I've been digging a bit more today and bisected the regression to: commit 7968a5dd492ccc38345013e534ad4c8d6eb60ed1 Input: synaptics - add support for Relative mode

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Daniel Drake
On Fri, Apr 20, 2012 at 1:21 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: So Peter and I have been discussing a problem I observed on my brand new ThinkPad X220 and it's multitouch clickpad. I've been digging a bit more today and bisected the regression to: commit

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Dmitry Torokhov
On Fri, Apr 20, 2012 at 08:27:37AM -0600, Daniel Drake wrote: On Fri, Apr 20, 2012 at 1:21 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: So Peter and I have been discussing a problem I observed on my brand new ThinkPad X220 and it's multitouch clickpad. I've been digging a bit

Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

2012-04-20 Thread Benjamin Herrenschmidt
On Fri, 2012-04-20 at 10:01 -0700, Dmitry Torokhov wrote: It looks we lost a condition in synaptics_set_advanced_gesture_mode(). It used to be: if (!(SYN_CAP_ADV_GESTURE(priv-ext_cap_0c) || SYN_CAP_IMAGE_SENSOR(priv-ext_cap_0c))) return 0; and