[PATCH] modesetting: prefer primary crtc when picking over nothing

So we had a bug report that epiphany was rendering slow on modesetting + DRI3, that I tracked down to the fact it was rendering offscreen to a single buffer. However due to this rendering being offscreen we were getting the fake crtc chosen by the X server as the window didn't overlap any active CR

Re: modesetting: prefer primary crtc when picking over nothing

Hi, On 03-08-16 02:24, Dave Airlie wrote: So we had a bug report that epiphany was rendering slow on modesetting + DRI3, that I tracked down to the fact it was rendering offscreen to a single buffer. However due to this rendering being offscreen we were getting the fake crtc chosen by the X serv

Re: [PATCH] modesetting: prefer primary crtc when picking over nothing

On 03.08.2016 09:24, Dave Airlie wrote: > So we had a bug report that epiphany was rendering slow on > modesetting + DRI3, that I tracked down to the fact it was > rendering offscreen to a single buffer. However due to this > rendering being offscreen we were getting the fake crtc > chosen by the X

Re: [PATCH] modesetting: prefer primary crtc when picking over nothing

Dave Airlie writes: > So we had a bug report that epiphany was rendering slow on > modesetting + DRI3, that I tracked down to the fact it was > rendering offscreen to a single buffer. However due to this > rendering being offscreen we were getting the fake crtc > chosen by the X server as the win

Re: [PATCH] modesetting: prefer primary crtc when picking over nothing

Michel Dänzer writes: > This can indeed only avoid the problem by accident, since there's no > guarantee that the primary output is even connected. Actually, he used the RRFirstOutput function which does find something connected to an active CRTC, so at least it should work as he intended? --

Re: [PATCH] modesetting: prefer primary crtc when picking over nothing

On 03.08.2016 14:10, Keith Packard wrote: > Michel Dänzer writes: > >> This can indeed only avoid the problem by accident, since there's no >> guarantee that the primary output is even connected. > > Actually, he used the RRFirstOutput function which does find something > connected to an active

Re: [PATCH] modesetting: prefer primary crtc when picking over nothing

Michel Dänzer writes: > I stand corrected. I was thinking of the primary output as reported by > xrandr. I had to actually go read the code; I had not remembered what 'RRFirstOutput' did either. Shockingly, there's a *comment* describing what it does. What was that author thinking! -- -keith