Re: pull request: output slave

2012-07-06 Thread Keith Packard
Dave Airlie writes: > the ddx has to create them at CreateScreenResources time, just like > crtc/outputs, the startup ordering demands it :) oh, so you'd have to wrap CreateScreenResources... Yeah, not worth the pain for an intermediate state like this. >> PixmapSyncDirtyHelper might be made fa

Re: pull request: output slave

2012-07-06 Thread Dave Airlie
some comments inline, I've removed anything I agree with and have fixed up patches > (Hrm, would also be nice if this patch created provider objects for the > screens so that we could test the protocol support here) the ddx has to create them at CreateScreenResources time, just like crtc/outputs,

Re: pull request: output slave

2012-07-06 Thread Adam Jackson
On 7/6/12 6:11 AM, Dave Airlie wrote: This depends on the previous pull req and contains all the patches in it. The pull below is from the top of that tree. This is all the randr changes + output slave additions. Looks good. For the series: Reviewed-by: Adam Jackson - ajax ___

Re: pull request: output slave

2012-07-06 Thread Keith Packard
Dave Airlie writes: I'm just going to do review here, reading from the git tree diffs. > randr: add provider object and provider property support (v6) Given that the _rrProvider structs are per-screen, any devPrivate stuff could live in the screen private instead; otherwise, I'd suggest m

pull request: output slave

2012-07-06 Thread Dave Airlie
This depends on the previous pull req and contains all the patches in it. The pull below is from the top of that tree. This is all the randr changes + output slave additions. The following changes since commit 74b786f7cee5723468bba251a2155a65770b2ad4: xfree86: add autoAddGPU option (v2) (2012-