https://bugs.freedesktop.org/show_bug.cgi?id=39282
--- Comment #29 from Florian Evers florian-ev...@gmx.de 2011-12-02 00:42:46
PST ---
Some additional comments.
I never saw noisy widgets again since I use 0x77553311. But all the other
glitches remain.
Then, I see random misbehavior of the
Hi Tormod,
Tormod Volden wrote:
Let the user know that we actually hit an error.
This fixes gcc format-security warnings as well.
Also add a missing newline in one error message.
Signed-off-by: Tormod Volden debian.tor...@gmail.com
---
avivotool.c |2 +-
radeonreg.c |2 +-
fatal() is never called with a user-specified argument so it is safe
to pass its argument as an fprintf format string, but gcc doesn't know
that. Use fprintf(stderr, %s, arg) to make the intent clearer.
This fixes the build in distro setups that pass -Werror=format-security.
Based on the patch
From: Tormod Volden debian.tor...@gmail.com
$ test
$ radeontool romtables test
$ PCI ROM signature 0x55 0xaa missing$
Signed-off-by: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Jonathan Nieder jrnie...@gmail.com
---
radeontool.c |2 +-
1 files changed, 1 insertions(+), 1
From: Tormod Volden debian.tor...@gmail.com
Let the user know which message corresponds to the error that
caused the tool to exit.
[jn: using fatal error: instead of Error: for consistency with
usage:]
Signed-off-by: Tormod Volden lists.tor...@gmail.com
Signed-off-by: Jonathan Nieder
This is more robust: if a caller forgets the final newline, the
resulting messages that run together can be hard to read, whereas if a
caller adds an extra newline, it just means an extra blank line in the
output.
Rename the function when changing the interface so any callers that
have not been
Hi,
Tormod Volden wrote:
From: Tormod Volden debian.tor...@gmail.com
Signed-off-by: Tormod Volden debian.tor...@gmail.com
I think there's a line or so of room here to explain the purpose of
this patch. :)
[...]
--- a/radeontool.c
+++ b/radeontool.c
@@ -2951,6 +2951,8 @@ void
Tormod Volden wrote:
[Subject: Only print current status in usage() if we are root]
[...]
--- a/radeontool.c
+++ b/radeontool.c
[...]
@@ -141,13 +143,24 @@ static void radeon_set_mcind(unsigned long offset,
const char *name,
static void usage(void)
{
+const char *dac_status =
Tormod Volden wrote:
Consistently use int for register values and long for register offsets.
Nice idea.
[...]
--- a/atombios_tables.c
+++ b/atombios_tables.c
@@ -634,7 +634,7 @@ static void radeon_print_pp_misc(uint32_t misc)
if (misc ATOM_PM_MISCINFO_THERMAL_DIODE_MODE)
https://bugs.freedesktop.org/show_bug.cgi?id=38030
--- Comment #41 from Kovid Goyal ko...@kovidgoyal.net 2011-12-02 23:31:27 PST
---
Although you were probably asking Phil to do this, as I was rebooting my
machine anyway, I commented out the line
drm_helper_hpd_irq_event(dev);
rebuilt the
10 matches
Mail list logo
