Re: [PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-14 Thread Michel Dänzer
On Mit, 2011-07-13 at 16:28 +1000, Benjamin Herrenschmidt wrote: The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still want to byteswap the ring itself and the IBs, so we don't touch that but we remove

Re: [PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-14 Thread Benjamin Herrenschmidt
On Thu, 2011-07-14 at 17:19 +0200, Michel Dänzer wrote: On Mit, 2011-07-13 at 16:28 +1000, Benjamin Herrenschmidt wrote: The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still want to byteswap the ring

Re: [PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-13 Thread Alex Deucher
On Wed, Jul 13, 2011 at 2:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still want to byteswap the ring itself and the IBs, so we don't touch

[PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-13 Thread Benjamin Herrenschmidt
The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still want to byteswap the ring itself and the IBs, so we don't touch that but we remove setting of the byteswap bits in CP_RB_RPTR_ADDR and IH_CNTL. In

[PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-13 Thread Benjamin Herrenschmidt
The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still want to byteswap the ring itself and the IBs, so we don't touch that but we remove setting of the byteswap bits in CP_RB_RPTR_ADDR and IH_CNTL. In

Re: [PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-13 Thread Benjamin Herrenschmidt
On Wed, 2011-07-13 at 10:42 -0400, Alex Deucher wrote: On Wed, Jul 13, 2011 at 2:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: The writeback ring pointer and IH ring pointer are read using le32_to_cpu so we do not want the chip to byteswap them on big-endian. We still

Re: [PATCH 3/6] drm/radeon: Writeback endian fixes

2011-07-13 Thread Alex Deucher
On Wed, Jul 13, 2011 at 5:41 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2011-07-13 at 10:42 -0400, Alex Deucher wrote: On Wed, Jul 13, 2011 at 2:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: The writeback ring pointer and IH ring pointer are read using