Re: [PATCH] Only align screen / scanout pixmap height where necessary

2015-10-07 Thread Michel Dänzer
On 02.10.2015 23:46, Alex Deucher wrote: > On Fri, Oct 2, 2015 at 5:11 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> When using glamor acceleration, the pixmap's header has to have a height >> that matches exactly what the actual height is minus the GP

[PATCH xf86-video-amdgpu] Don't advertise rotation support without hardware acceleration

2015-10-07 Thread Michel Dänzer
From: Michel Dänzer Rotation currently doesn't work without acceleration (doesn't actually rotate with Option "NoAccel", crashes with Option "AccelMethod" "none" or when glamor fails to initialize) and would probably be too slow anyway. Signed-off-by: M

[PATCH xf86-video-amdgpu] Don't advertise rotation support without hardware acceleration v2

2015-10-07 Thread Michel Dänzer
From: Michel Dänzer Rotation currently doesn't work without acceleration (doesn't actually rotate with Option "NoAccel", crashes with Option "AccelMethod" "none" or when glamor fails to initialize) and would probably be too slow anyway. v2: Also remove

[PATCH 1/2] Eliminate redundant data parameter from drmmode_crtc_scanout_create

2015-10-13 Thread Michel Dänzer
From: Michel Dänzer drmmode_crtc_scanout_create just needs to call drmmode_crtc_scanout_allocate when scanout->bo is NULL. This makes it clearer to the reader / compiler that drmmode_crtc_scanout_create doesn't dereference scanout->bo when it's NULL. Signed-off-by: Michel

[PATCH 2/2] Properly handle drmModeAddFB failure in drmmode_crtc_scanout_allocate

2015-10-13 Thread Michel Dänzer
From: Michel Dänzer We were printing an error message, but not propagating the failure. That would probably lead to trouble down the road. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/drmmode_display.c b/src

[PATCH] Call xf86CrtcRotate from initial drmmode_set_desired_modes call

2015-10-16 Thread Michel Dänzer
From: Michel Dänzer Fixes various problems when rotation is specified in xorg.conf. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92475 Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/drmmode_display.c b/src

Re: dual Radeon graphics cards and Xrandr 1.4

2015-10-19 Thread Michel Dänzer
ve doesn't help, maybe try swapping the 1 and 0 here. I can never remember which way around they need to be. :) -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati

Re: dual Radeon graphics cards and Xrandr 1.4

2015-10-19 Thread Michel Dänzer
ests (7.5.0 and git), but does not occur when > I run X with Xinerama. It's because Xorg uses software cursors for RandR 1.4 multihead. IIRC it might be fixed with xserver Git master, but I'm not sure the patches have landed yet. -- Earthling Michel Dänzer |

Re: [PATCH xf86-video-amdgpu] Add Stoney support

2015-10-22 Thread Michel Dänzer
On 23.10.2015 01:52, Alex Deucher wrote: > From: Samuel Li > > (agd): rebase > > Signed-off-by: Samuel Li Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa

Re: [PATCH] Handle failures in setting a CRTC to a DRM mode properly

2015-10-23 Thread Michel Dänzer
output_count, &kmode) != 0) { xf86DrvMsg(crtc->scrn->scrnIndex, X_ERROR, "failed to set mode: %s", strerror(errno)); ret = FALSE

Re: [PATCH v2] Handle failures in setting a CRTC to a DRM mode properly

2015-10-26 Thread Michel Dänzer
the user switched to > another VT. > > Signed-off-by: Stephen Chandler Paul > Reviewed-by: Michel Dänzer > --- > Changes > * We no longer assign the return value of drmModeSetCrtc to ret, instead we > just check it in the conditional >

Re: [PATCH xf86-video-amdgpu] Fix the X crash for pci_probe path

2015-10-26 Thread Michel Dänzer
t;pEnt = pEnt; > + info->PciInfo = xf86GetPciInfoForEntity(info->pEnt->index); > + > + if (!amdgpu_open_drm_master(pScrn)) > goto error_fd; > - } > > pAMDGPUEnt->fd_ref = 1; &

Re: [PATCH v2] Handle failures in setting a CRTC to a DRM mode properly

2015-10-26 Thread Michel Dänzer
On 26.10.2015 20:01, Emil Velikov wrote: > On 26 October 2015 at 10:55, Daniel Martin wrote: >> On 26 October 2015 at 10:39, Michel Dänzer wrote: >>>> diff --git a/src/drmmode_display.c b/src/drmmode_display.c >>>> index 64e79d4..f0f121e 100644 >>>&g

Re: [PATCH xf86-video-amdgpu] Fix crash in PCI probe path (v2)

2015-10-28 Thread Michel Dänzer
e patch looks good. The pAMDGPUEnt->fd = 0 assignment under the error_amdgpu label could be removed as well, but I'm fine with leaving it. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati

Re: [PATCH xf86-video-amdgpu 1/2] Fix crash in PCI probe path (v3)

2015-10-28 Thread Michel Dänzer
o the memory pointed to by pAMDGPUEnt is freed immediately after the removed assignment. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati

Re: [PATCH xf86-video-amdgpu 1/2] Fix crash in PCI probe path (v3)

2015-10-28 Thread Michel Dänzer
tatic Bool AMDGPUDriverFunc(ScrnInfoPtr scrn, xorgDriverFuncOp op, void > *data) > These changes make sense, but are again logically separate from the crash fix. If you want, I can send out a new series with the logical changes split up into separate patches. -- Earthling Michel Dänzer

Re: [PATCH xf86-video-amdgpu 2/2] Fix warnings for unused variables

2015-10-28 Thread Michel Dänzer
return; > These look good, but will be obsoleted by pending changes of mine which remove info->dri2.drm_fd and info->drmmode->fd in favour of pAMGPUEnt->fd. It's probably best if I send out a new series combining your changes and mine, if you're okay with that.

Re: [PATCH xf86-video-amdgpu] Call present_event_notify directly if target_msc <= crtc_msc (v2)

2015-10-28 Thread Michel Dänzer
for this? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listi

Re: [PATCH xf86-video-amdgpu] Call present_event_notify directly if target_msc <= crtc_msc (v2)

2015-10-29 Thread Michel Dänzer
de. Makes sense, but I'd like to wait for the xserver patch to land first, to avoid diverging behaviour between the driver and xserver. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

[PATCH xf86-video-amdgpu 5/5] Remove amdgpu_reference_drm_fd

2015-10-29 Thread Michel Dänzer
From: Michel Dänzer Increase pAMDGPUEnt->fd_ref in the probe code instead when we're reusing the existing fd. The previous reference counting was imbalanced, so pAMDGPUEnt->fd_ref could never go to 0. Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 9 - src/amdgpu_

[PATCH xf86-video-amdgpu 1/5] Remove dead code from probe paths

2015-10-29 Thread Michel Dänzer
From: Michel Dänzer amdgpu_get_scrninfo allocates the memory pointed to by pAMDGPUEnt just before it calls amdgpu_open_drm_master, so pAMDGPUEnt->fd is always 0 in the latter. Also, no need to clear pAMDGPUEnt->fd just before freeing the memory it's stored in. Signed-off-by: Mi

[PATCH xf86-video-amdgpu 4/5] Remove info->dri2.drm_fd and info->drmmode->fd

2015-10-29 Thread Michel Dänzer
From: Michel Dänzer Use pAMDGPUEnt->fd everywhere instead. Signed-off-by: Michel Dänzer --- src/amdgpu_bo_helper.c | 5 +-- src/amdgpu_dri2.c | 49 +++-- src/amdgpu_dri2.h | 1 - src/amdgpu_dri3.c | 3 +- src/amdgpu_glamor.c| 4 +- src/amdgpu_km

[PATCH xf86-video-amdgpu 3/5] Pass struct pci_device *pci_dev directly to amdgpu_get_scrninfo

2015-10-29 Thread Michel Dänzer
From: Jammy Zhou Instead of throwing away the type information by passing it as a void*. Signed-off-by: Michel Dänzer --- src/amdgpu_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c index 444e9b6..61605b9 100644 --- a/src

[PATCH xf86-video-amdgpu 2/5] Fix crash in PCI probe path (v4)

2015-10-29 Thread Michel Dänzer
ode in amdgpu_open_drm_master, so that the crash can be fixed. v4: (md) Remove unused parameter entity_num, split out logically separate changes v3: some more cleanup v2: switch to pAMDGPUEnt->fd, and update the commit message Signed-off-by: Jammy Zhou Signed-off-by: Michel Dänzer --- src/amdgpu_pro

[PATCH xf86-video-amdgpu 3/3] Move scrn/info declaration inside USE_GLAMOR in amdgpu_dri3_fd_from_pixmap

2015-11-02 Thread Michel Dänzer
From: Michel Dänzer Fixes warning when building with --disable-glamor: ../../src/amdgpu_dri3.c: In function 'amdgpu_dri3_fd_from_pixmap': ../../src/amdgpu_dri3.c:135:16: warning: unused variable 'info' [-Wunused-variable] AMDGPUInfoPtr info = AMDGPUPTR(scrn);

[PATCH xf86-video-amdgpu 1/3] Don't use AMDGPUEntPriv in AMDGPUFreeRec

2015-11-02 Thread Michel Dänzer
From: Michel Dänzer It crashes if info == NULL. Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c index 5e17525..41f01b3 100644 --- a/src/amdgpu_kms.c +++ b/src/amdgpu_kms.c @@ -107,7

[PATCH xf86-video-amdgpu 2/3] Call AMDGPUFreeRec from AMDGPUFreeScreen_KMS even if info == NULL

2015-11-02 Thread Michel Dänzer
From: Michel Dänzer It's safe now. Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c index 41f01b3..fd89ba2 100644 --- a/src/amdgpu_kms.c +++ b/src/amdgpu_kms.c @@ -1031,15 +1031,10 @@ static

Re: [PATCH xf86-video-amdgpu] Call present_event_notify directly if target_msc <= crtc_msc (v2)

2015-11-02 Thread Michel Dänzer
ence. Can you provide more details about what exactly happens with and without this patch? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-ati

Re: [PATCH xf86-video-amdgpu] Call present_event_notify directly if target_msc <= crtc_msc (v2)

2015-11-03 Thread Michel Dänzer
ic numbers? Otherwise, it's hard for me to imagine how this could make a significant difference. > -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Monday, November 02, 2015 5:44 PM > To: Zhou, Jammy > Cc: xorg-driver-ati@lists.x.org >

Re: [PATCH xf86-video-amdgpu] Call present_event_notify directly if target_msc <= crtc_msc (v2)

2015-11-03 Thread Michel Dänzer
uit the userspace event delivery as it should, or the event delivery/processing is getting delayed for some reason. It would be good to get to the bottom of that instead of just papering over it in the Xorg driver. -- Earthling Michel Dänzer | http://www.amd.com Libre so

[PATCH 1/2] glamor: Restore ScreenRec hooks during CloseScreen

2015-11-10 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/radeon.h | 12 src/radeon_glamor.c | 20 src/radeon_glamor.h | 2 ++ src/radeon_glamor_wrappers.c | 5 - src/radeon_kms.c | 2 ++ 5 files changed, 32

[PATCH 2/2] glamor: Deal with glamor_egl_destroy_textured_pixmap being removed

2015-11-10 Thread Michel Dänzer
From: Michel Dänzer When it's not available, it's safe to call down to the glamor DestroyPixmap hook instead. Signed-off-by: Michel Dänzer --- configure.ac| 6 ++ src/radeon_glamor.c | 18 ++ 2 files changed, 24 insertions(+) diff --git a/conf

[PATCH 0/8] Fixes ported from xf86-video-amdgpu

2015-11-10 Thread Michel Dänzer
These are the remaining fixes from xf86-video-amdgpu which hadn't been ported to radeon yet. Once these are applied, we can cut a release. [PATCH 1/8] dri2: Avoid calculation with undefined msc value [PATCH 2/8] Simplify pick best crtc to fold two loops into one [PATCH 3/8] Clean up allocation in

[PATCH 4/8] Simplify drmmode_set_mode_major() and avoid leaking memory.

2015-11-10 Thread Michel Dänzer
From: Tom St Denis The function would leak the memory allocated for output_ids. This patch addresses that as well as simplifies the logic somewhat. Signed-off-by: Tom St Denis (ported from amdgpu commit 460560502a1bdf26d06f3c30df46fa9f28ffb9e5) Signed-off-by: Michel Dänzer --- src

[PATCH 2/8] Simplify pick best crtc to fold two loops into one

2015-11-10 Thread Michel Dänzer
From: Tom St Denis This patch folds the two for loops from radeon_pick_best_crtc() into one to reduce the LOC and make the routine easier to read. Signed-off-by: Tom St Denis (ported from amdgpu commit 3055724aef76a624718f26d5f0f9e9d567ffbcfb) Signed-off-by: Michel Dänzer --- src

[PATCH 1/8] dri2: Avoid calculation with undefined msc value

2015-11-10 Thread Michel Dänzer
From: Tom St Denis If the get_msc() call fails for any reason we should avoid updating the vblank counter delta with undefined data. Signed-off-by: Tom St Denis Signed-off-by: Michel Dänzer (minor fixups) (ported from amdgpu commit 8823c3d4c6db70cff7699b31088f2d92db8faaf4) Signed-off-by

[PATCH 3/8] Clean up allocation in RADEONInitVideo()

2015-11-10 Thread Michel Dänzer
From: Tom St Denis The allocation of the adapters should use the correct sizeof (even if allocating an array of pointers). Signed-off-by: Tom St Denis (ported from amdgpu commit db3bb2061b9ac16b0922d9afae99874820356a04) Signed-off-by: Michel Dänzer --- src/radeon_video.c | 2 +- 1 file

[PATCH 7/8] Properly handle drmModeAddFB failure in drmmode_crtc_scanout_allocate

2015-11-10 Thread Michel Dänzer
From: Michel Dänzer We were printing an error message, but not propagating the failure. That would probably lead to trouble down the road. (ported from amdgpu commit 21e72fb2418b5cc7fc849a9cf951186e209036b0) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 6 +- 1 file changed, 5

[PATCH 5/8] Don't advertise rotation support without hardware acceleration v2

2015-11-10 Thread Michel Dänzer
From: Michel Dänzer Rotation currently doesn't work without acceleration (doesn't actually rotate with Option "NoAccel", crashes with Option "AccelMethod" "none" or when glamor fails to initialize) and would probably be too slow anyway. v2: Also remove

[PATCH 8/8] Clean up radeon_dri2_create_buffer2()

2015-11-10 Thread Michel Dänzer
From: Tom St Denis Remove the depth_pixmap variable from the function and clear out any dead/odd behaviour that results. Signed-off-by: Tom St Denis (ported from amdgpu commit 6000aef4e2f0a121b94023484406fb6f04688f74) Signed-off-by: Michel Dänzer --- src/radeon_dri2.c | 14 +++--- 1

[PATCH 6/8] Eliminate redundant data parameter from drmmode_crtc_scanout_create

2015-11-10 Thread Michel Dänzer
From: Michel Dänzer drmmode_crtc_scanout_create just needs to call drmmode_crtc_scanout_allocate when scanout->bo is NULL. This makes it clearer to the reader / compiler that drmmode_crtc_scanout_create doesn't dereference scanout->bo when it's NULL. (ported fr

[PATCH xf86-video-amdgpu 3/9] Rename Option "NoAccel" to "Accel"

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer Removes the need for a double negation when forcing acceleration on. Note that this change is backwards compatible, as the option parser automagically handles the 'No' prefix. (ported from radeon commit cc615d06db0332fc6e673b55632bcc7bf957b44b) Signed-off-by: Mic

[PATCH xf86-video-amdgpu 4/9] PRIME: Don't advertise offload capabilities when acceleration is disabled

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer Xorg tends to crash if the user tries to actually use the offload capabilities with acceleration disabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57200 (ported from radeon commit c74de9fec13fac2c836bb2a07ae6f90e1d61e667) Signed-off-by: Michel Dänzer

[PATCH xf86-video-amdgpu 1/9] Fixes ported from radeon

2015-11-11 Thread Michel Dänzer
These are the remaining fixes from radeon which hadn't been ported to xf86-video-amdgpu yet. Once these are applied, we can cut a release. [PATCH xf86-video-amdgpu 1/9] dri2: Handle PRIME for source buffer as [PATCH xf86-video-amdgpu 2/9] Use own thunk function instead of [PATCH xf86-video-amdgpu

[PATCH xf86-video-amdgpu 6/9] Skip disabled CRTCs in amdgpu_scanout_(do_)update

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer The vblank / page flip ioctls don't work as expected for a disabled CRTC. (ported from radeon commit acc11877423ecd81a6e0a7f38466f80e43efee20) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH xf86-video-amdgpu 1/9] dri2: Handle PRIME for source buffer as well in amdgpu_dri2_copy_region2

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77810 (ported from radeon commit c84230d686c078aac1dc98d82153f8b02521b2e1) Signed-off-by: Michel Dänzer --- src/amdgpu_dri2.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/amdgpu_dri2

[PATCH xf86-video-amdgpu 9/9] Handle failures in setting a CRTC to a DRM mode properly

2015-11-11 Thread Michel Dänzer
From: Stephen Chandler Paul This fixes a bug where running the card out of PPLL's when hotplugging another monitor would result in all of the displays going blank and failing to work properly until X was restarted or the user switched to another VT. [Michel Dänzer: Pass errno instead of -r

[PATCH xf86-video-amdgpu 7/9] Do not link amdgpu_drv.so against libpciaccess

2015-11-11 Thread Michel Dänzer
From: Emil Velikov Not used directly. Signed-off-by: Emil Velikov (ported from radeon commit fcb32231a38f9461d12720cbf72f63502197a711) Signed-off-by: Michel Dänzer --- configure.ac| 3 --- src/Makefile.am | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac

[PATCH xf86-video-amdgpu 2/9] Use own thunk function instead of shadowUpdatePackedWeak

2015-11-11 Thread Michel Dänzer
From: Adam Jackson I plan to delete the Weak functions from a future server. Signed-off-by: Adam Jackson (ported from radeon commit 851b2cf8714618843725f6d067915375485ade9d) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[PATCH xf86-video-amdgpu 5/9] Prefer drmModeSetCursor2 over drmModeSetCursor

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer The former includes information about the position of the hotspot within the cursor image. Copied from xf86-video-modesetting. (ported from radeon commit c9f8f642fd495937400618a4fc25ecae3ffc) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 17

[PATCH xf86-video-amdgpu 8/9] Call xf86CrtcRotate from initial drmmode_set_desired_modes call

2015-11-11 Thread Michel Dänzer
From: Michel Dänzer Fixes various problems when rotation is specified in xorg.conf. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92475 (ported from radeon commit 548e97b3b7d1e94075a54ca2bb4eb683025098a7) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 2 ++ 1 file changed

[ANNOUNCE] xf86-video-ati 7.6.0

2015-11-11 Thread Michel Dänzer
consistent default eg_tile_split in evergreen_accel.c Make selection between DRI2 and DRI3 consistent with other drivers. (v2) Michel Dänzer (78): Remove duplicate OPTION_PAGE_FLIP entry PRIME: Don't advertise offload capabilities when acceleration is disabled Prefe

[ANNOUNCE] xf86-video-ati 7.6.1

2015-11-11 Thread Michel Dänzer
This is a brown paper bag release fixing a double-free bug in the 7.6.0 release. I could swear I'd tested this appropriately yesterday, but apparently not. :( Michel Dänzer (3): Post 7.6.0 release version bump Remove duplicate free(output_ids) call Set version for

Re: [PATCH xf86-video-amdgpu] Use render node for DRI3 if available

2015-11-17 Thread Michel Dänzer
Bool > amdgpu_dri3_screen_init(ScreenPtr screen) > { > ScrnInfoPtr scrn = xf86ScreenToScrn(screen); > + AMDGPUInfoPtr info = AMDGPUPTR(scrn); > + > + info->render_node = get_render_node(screen); However, couldn't you just use drmGetRenderDeviceNameFromFd here instea

Re: [PATCH xf86-video-amdgpu 1/2] Prefer drmModeSetCursor2 over drmModeSetCursor

2015-11-17 Thread Michel Dänzer
On 18.11.2015 02:54, Alex Deucher wrote: > From: Michel Dänzer > > The former includes information about the position of the hotspot within > the cursor image. > > Copied from xf86-video-modesetting. > > Reviewed-by: Alex Deucher >

[ANNOUNCE] xf86-video-amdgpu 1.0.0

2015-11-19 Thread Michel Dänzer
le acceleration by default on Hawaii ddx: remove AMDGPUIsAccelWorking ddx: use amdgpu_query_crtc_from_id Mario Kleiner (2): Allow/Fix use of multiple ZaphodHead outputs per x-screen. Make selection between DRI2 and DRI3 consistent with other drivers. (v2) Michel Dänzer (

[PATCH xf86-video-amdgpu 2/2] glamor: Deal with glamor_egl_destroy_textured_pixmap being removed

2015-11-19 Thread Michel Dänzer
From: Michel Dänzer When it's not available, it's safe to call down to the glamor DestroyPixmap hook instead. (ported from radeon commit 10b7c3def58bb34acc38f076bc230e25b454ab79) Signed-off-by: Michel Dänzer --- configure.ac| 6 ++ src/amdgpu_glamor.c | 18 +++

[PATCH xf86-video-amdgpu 1/2] glamor: Restore all ScreenRec hooks during CloseScreen

2015-11-19 Thread Michel Dänzer
From: Michel Dänzer (ported from radeon commit 535e5438b2c32f774b9c8c27ee0289b4749548ef) Signed-off-by: Michel Dänzer --- src/amdgpu_drv.h | 8 src/amdgpu_glamor.c | 20 src/amdgpu_glamor.h | 1 + src/amdgpu_glamor_wrappers.c | 5

Re: [PATCH xf86-video-amdgpu] Use render node for DRI3 if available (v2)

2015-11-20 Thread Michel Dänzer
On 20.11.2015 18:03, Jammy Zhou wrote: > v2: refine the code I'd either add a specific log of the changes in v2, or just leave it out. Either way, Reviewed-and-Tested-by: Michel Dänzer P.S. Which branch did you create the patch against? The context in the configure.ac hunk doesn

[PATCH] Don't advertise any PRIME offloading capabilities without acceleration

2015-11-20 Thread Michel Dänzer
From: Michel Dänzer Acceleration is required even for display offloading. Trying to enable display offloading without acceleration resulted in a crash. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a

Re: [PATCH] Don't advertise any PRIME offloading capabilities without acceleration

2015-11-23 Thread Michel Dänzer
On 21.11.2015 01:02, Alex Deucher wrote: > On Fri, Nov 20, 2015 at 4:49 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Acceleration is required even for display offloading. Trying to enable >> display offloading without acceleration resulted in a crash. >>

Re: [ANNOUNCE] xf86-video-amdgpu 1.0.0

2015-11-23 Thread Michel Dänzer
those, and the modesetting driver works well enough for you, there's nothing wrong with using it. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

[PATCH] Load fb module before glamoregl/shadow modules

2015-12-02 Thread Michel Dänzer
From: Michel Dänzer Fixes unresolved symbols on some systems. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93105 Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index

[PATCH xf86-video-amdgpu] sync: Check if miSyncShmScreenInit symbol is resolved at runtime

2015-12-10 Thread Michel Dänzer
From: Michel Dänzer It may be disabled in the Xorg build, either explicitly or because the xshmfence library isn't available. Signed-off-by: Michel Dänzer --- src/amdgpu_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/amdgpu_sync.c b/src/amdgpu_sync.c index ba

[PATCH 1/2] HAS_DIRTYTRACKING_ROTATION also supports multiple CRTCs

2015-12-23 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 99dc08b..fa46d56 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -952,7 +952,7

[PATCH 2/2] Build RandR 1.4 provider name from chipset name and bus ID

2015-12-23 Thread Michel Dänzer
From: Michel Dänzer Instead of just "radeon", it's now e.g. "KAVERI @ pci::00:01.0". Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmod

Re: AMD Radeon HD 8210

2015-12-23 Thread Michel Dänzer
On 24.12.2015 01:33, konone...@interzet.ru wrote: > Motherboard GA-E2100N (rev. 1.0), video card AMD Radeon HD 8210, port > xf86-video-ati-7.5.0_3 do not support, only vesa, help me Please provide the Xorg log file and the output of dmesg. -- Earthling Michel

Re: [PATCH 2/2] Build RandR 1.4 provider name from chipset name and bus ID

2015-12-24 Thread Michel Dänzer
;t possible before (several GPUs driven by the radeon driver). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg

Re: [Bug 90789] Vsync doesn't work for rotated display

2015-12-25 Thread Michel Dänzer
ich makes the > conditional superfluous. I did say it was a preliminary patch. :) > I'm guessing there may still be some merit to conditionally setting > driverIsPerformingTransform but the details simply need to be worked out? Exactly. -- Earthling Michel Dänzer

Re: AMD Radeon HD 8210

2016-01-03 Thread Michel Dänzer
>> >> Please provide the Xorg log file and the output of dmesg. The dmesg you sent me doesn't show any trace of the radeon kernel driver. xf86-video-ati 7.5.0 requires the radeon KMS kernel driver. -- Earthling Michel Dänzer | htt

Re: Black window with Gnome3 (xf86-video-ati 1:7.6.1-1)

2016-01-05 Thread Michel Dänzer
ithout Option "Accel" "off". -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-driver-ati mailing list xorg-driver-ati@lists.x

Re: Black window with Gnome3 (xf86-video-ati 1:7.6.1-1)

2016-01-06 Thread Michel Dänzer
And tooltips sometimes are shown incorrect: This could be https://bugs.freedesktop.org/show_bug.cgi?id=90264 . Does not setting AccelMethod to glamor avoid any of the issues? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and

[PATCH xf86-video-amdgpu 2/3] Remove pci_dev test from amdgpu_get_scrninfo

2016-01-08 Thread Michel Dänzer
From: Michel Dänzer The pci_dev parameter can never be NULL since we only support KMS. Reported-by: Tom St Denis Signed-off-by: Michel Dänzer --- src/amdgpu_probe.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c index

[PATCH xf86-video-amdgpu 3/3] Only call amdgpu_bus_id once in each probe path

2016-01-08 Thread Michel Dänzer
From: Michel Dänzer Instead of up to twice as before. Signed-off-by: Michel Dänzer --- src/amdgpu_probe.c | 52 +--- 1 file changed, 25 insertions(+), 27 deletions(-) diff --git a/src/amdgpu_probe.c b/src/amdgpu_probe.c index f74eb29..ea9ffa7

[PATCH xf86-video-amdgpu 1/3] Re-use PCI bus ID code from kernel_open_fd in kernel_mode_enabled

2016-01-08 Thread Michel Dänzer
From: Michel Dänzer Avoids failures due to DRICreatePCIBusID not being available in some cases. Signed-off-by: Michel Dänzer --- src/amdgpu_probe.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/amdgpu_probe.c b/src

Re: [PATCH xf86-video-amdgpu] Initialize drmmode_crtc dpms_mode to DPMSModeOff

2016-01-13 Thread Michel Dänzer
mModeGetCrtc(pAMDGPUEnt->fd, mode_res->crtcs[num]); > drmmode_crtc->drmmode = drmmode; > + drmmode_crtc->dpms_mode = DPMSModeOff; > crtc->driver_private = drmmode_crtc; > drmmode_crtc_hw_id(crtc); Reviewed and pushed, thanks! -- Earthling Michel Dänzer

[PATCH] Set the RandR primary output on startup if Xorg hasn't

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer Fixes xrandr (XRRGetOutputPrimary) not reporting any output as primary after startup. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index d459740..971f11c 100644

[PATCH] Fix RandR CRTC transforms

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer Currently, Xorg will only transform the cursor as of the first time the cursor image changes after a transform is set. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80678 Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 17 - 1 file changed

[PATCH xf86-video-amdgpu] Set the RandR primary output on startup if Xorg hasn't

2016-01-19 Thread Michel Dänzer
From: Michel Dänzer Fixes xrandr (XRRGetOutputPrimary) not reporting any output as primary after startup. (Ported from radeon commit b16856b25086ffb27365ac2249b8da921066ce62) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH xf86-video-amdgpu] Only map front buffer if necessary for ShadowFB

2016-01-25 Thread Michel Dänzer
From: Michel Dänzer Otherwise the front buffer may not be accessible by the CPU, because Mesa sets the AMDGPU_GEM_CREATE_NO_CPU_ACCESS flag for tiled buffers, because accessing tiled buffers with the CPU makes little sense. Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 3 ++- src

Re: possible kerning bug in LibreOffice on Ubuntu with xorg-driver-ati

2016-01-26 Thread Michel Dänzer
hypothesis. > not with the proprietary fglrx driver. When you tried that, maybe it was using the Radeon GPU for everything instead of the Intel one? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

[PATCH xf86-video-amdgpu] Only map front buffer if glamor acceleration is disabled (v2)

2016-01-28 Thread Michel Dänzer
From: Michel Dänzer Otherwise the front buffer may not be accessible by the CPU, because Mesa sets the AMDGPU_GEM_CREATE_NO_CPU_ACCESS flag for tiled buffers, because accessing tiled buffers with the CPU makes little sense. v2: Also handle Option "AccelMethod" "none" S

[PATCH] Set RADEON_GEM_NO_CPU_ACCESS flag for BOs which don't need CPU access

2016-01-28 Thread Michel Dänzer
From: Michel Dänzer Failing to do this was resulting in the kernel driver unnecessarily leaving open the possibility of CPU access to those BOs. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 6 -- src/radeon.h | 4 src/radeon_bo_helper.c | 7 +-- src

Re: Hybrid graphics - "radeon" driver unloaded, "modesetting" loaded?

2016-02-04 Thread Michel Dänzer
here. How can I get my radeon device back in the xrandr > providers and working via DRI_PRIME? I can see two problems here: Xorg unloads the radeon driver and loads the modesetting driver instead, and the modesetting driver doesn't advertise PRIME render offloading capability. I don'

Bug#813762: display: X.Org X server -- AMD/ATI Radeon display driver

2016-02-07 Thread Michel Dänzer
eric driver such as vesa. The Xorg log file and dmesg output will be necessary to determine if that is due to a configuration error or bug in another package, but it's most definitely not an xserver-xorg-video-radeon bug. -- Earthling Michel Dänzer | http://w

[PATCH xf86-video-amdgpu 2/3] Load fb module before glamoregl/shadow modules

2016-02-15 Thread Michel Dänzer
From: Michel Dänzer Fixes unresolved symbols on some systems. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93105 (ported from radeon commit 78fbca095ae9887a2d3de48bb07975e2d1126e68) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 8 1 file changed, 4 insertions(+), 4

[PATCH xf86-video-amdgpu 1/3] Don't advertise any PRIME offloading capabilities without acceleration

2016-02-15 Thread Michel Dänzer
From: Michel Dänzer Acceleration is required even for display offloading. Trying to enable display offloading without acceleration resulted in a crash. (ported from radeon commit b19417e2fddf4df725951aea5ad5e9558338f59e) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 22

[PATCH xf86-video-amdgpu 3/3] HAS_DIRTYTRACKING_ROTATION also supports multiple CRTCs

2016-02-15 Thread Michel Dänzer
From: Michel Dänzer (ported from radeon commit ff9a6b6f079a8419f4e6fadfee778060618bf735) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 40a134c..896b9d2 100644 --- a

Re: [PATCH xf86-video-amdgpu 1/3] Don't advertise any PRIME offloading capabilities without acceleration

2016-02-15 Thread Michel Dänzer
;> #endif >> } > > I see the factoring of if (info->use_glamor) out of setting the > capabilities flags, but I'm wondering whether 'info->dri2.available' > still matters? info->use_glamor currently can't be TRUE if info->d

[PATCH xf86-video-ati 3/6] Initialize drmmode_crtc dpms_mode to DPMSModeOff

2016-02-16 Thread Michel Dänzer
From: Mykola Lysenko This disables query of disabled pipes for drmWaitVBlank on X start Signed-off-by: Mykola Lysenko (ported from amdgpu commit 4eb9cedca080b30c57ded349a397620ee7d0cd46) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH xf86-video-ati 5/6] Move amdgpu_glamor_destroy_pixmap before amdgpu_glamor_create_pixmap

2016-02-16 Thread Michel Dänzer
From: jimqu The next commit will call the former from the latter. No functional change. Signed-off-by: JimQu (ported from amdgpu commit 5269a2228bff6023c1a7f3e8534027e1d7addc25) Signed-off-by: Michel Dänzer --- src/radeon_glamor.c | 70

[PATCH xf86-video-ati 4/6] Remove pci_dev test from amdgpu_get_scrninfo

2016-02-16 Thread Michel Dänzer
From: Michel Dänzer The pci_dev parameter can never be NULL since we only support KMS. Reported-by: Tom St Denis (ported from amdgpu commit 6e42c58375a4c3229da93c27bbd104af145c6163) Signed-off-by: Michel Dänzer --- src/radeon_probe.c | 5 + 1 file changed, 1 insertion(+), 4 deletions

[PATCH xf86-video-ati 6/6] glamor: Return NullPixmap on failure to create shareable pixmap

2016-02-16 Thread Michel Dänzer
(ported from amdgpu commit 2fcb7dadd3c71cd405cbbaafc777697538ca9c29) Signed-off-by: Michel Dänzer --- src/radeon_glamor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c index 6a12b33..cc2b1f2 100644 --- a/src/radeon_glamo

[PATCH xf86-video-ati 1/6] Use render node for DRI3 if available

2016-02-16 Thread Michel Dänzer
From: Jammy Zhou Signed-off-by: Jammy Zhou (ported from amdgpu commit ea558e645786b08d75307716036045170e97b43e) Signed-off-by: Michel Dänzer --- configure.ac | 2 +- src/radeon_dri3.c | 37 ++--- src/radeon_probe.h | 1 + 3 files changed, 36

[PATCH xf86-video-ati 2/6] sync: Check if miSyncShmScreenInit symbol is resolved at runtime

2016-02-16 Thread Michel Dänzer
From: Michel Dänzer It may be disabled in the Xorg build, either explicitly or because the xshmfence library isn't available. (ported from amdgpu commit 1d0b0c1794e65e581a48aa9fb19679d928d82a5d) Signed-off-by: Michel Dänzer --- src/radeon_sync.c | 7 +++ 1 file changed, 7 inser

Re: [PATCH xf86-video-ati 5/6] Move amdgpu_glamor_destroy_pixmap before amdgpu_glamor_create_pixmap

2016-02-16 Thread Michel Dänzer
On 16.02.2016 17:53, Ernst Sjöstrand wrote: > Wrong patch title. :-) Indeed, thanks! Fixed in patches 4 & 5 before pushing. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X de

[ANNOUNCE] xf86-video-amdgpu 1.0.1

2016-02-19 Thread Michel Dänzer
op of the upcoming Mesa 11.2 release. Michel Dänzer (6): sync: Check if miSyncShmScreenInit symbol is resolved at runtime Only map front buffer if glamor acceleration is disabled (v2) Don't advertise any PRIME offloading capabilities without acceleration Load fb mod

[PATCH xf86-video-ati] Remove radeon_scanout_flip_handler

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer No longer necessary now that radeon_drm_queue_handler can handle e->handler == NULL. Signed-off-by: Michel Dänzer --- src/radeon_kms.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/radeon_kms.c b/src/radeon_kms.c index 38f5c4e..d93a

[PATCH xf86-video-ati 2/2] DRI2: Also clear dri2_flipping when client disconnects before event

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer Fixes the following problem: With DRI3 enabled, run glxgears with LIBGL_DRI3_DISABLE=1, make it fullscreen and press Escape while it's still fullscreen. This could result in dri2_flipping not getting cleared, spuriously preventing apps using DRI3 from flipping. Signe

[PATCH xf86-video-ati 1/2] drm_queue: Don't abort events immediately from radeon_drm_abort_client

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer Keep them around until the DRM event arrives, but then call the abort functions instead of the handler functions. This is a prerequisite for the following fix. Signed-off-by: Michel Dänzer --- src/radeon_drm_queue.c | 18 +- 1 file changed, 13 insertions

<    1   2   3   4   5   6   7   8   9   10   >