On 09/03/2016 09:21 PM, dmg wrote:
> I think that the n+1 vs n widths can be easily handled by patching
> xournal to accept a n+1 width (and ignore it). So when it reads a file
> with more than
> n, it works, rather than failing as it is currently. I'll write the
> patch today.
Yes, of course --
On Sat, Sep 3, 2016 at 6:19 PM, Denis Auroux
wrote:
>
>>
> Yes, absolutely -- it should be a rendering option and should not affect
> anything in the file.
> The unfortunate issue is that a sequence of trapezoids has one extra width
> parameter (because the number of vertices is one more than the
Hi Daniel,
> what do you think about being this part of the rendering, but not of the
> storage of the lines?
Yes, absolutely -- it should be a rendering option and should not affect
anything in the file.
The unfortunate issue is that a sequence of trapezoids has one extra
width parameter (beca
Hi Denis,
what do you think about being this part of the rendering, but not of the
storage of the lines?
in other words, we store the lines with variable width (as we do today) but
we render them (optionally) with the trapezoid shapes?
about performance, it might be that we are rendering lines s
As far as I understand, the file format compatibility issue is simply
the number of width parameters.
Namely, a stroke composed of n line segments connecting (n+1) vertices
has n widths with my version of the code (one width for each segment),
and (n+1) widths with Immi's version (one width for
Hi Daniel,
From what I understand, the line rendering change in Immi's patch
primarily concerns variable-width strokes (pressure-sensitive). Xournal
renders them as a sequence of line segments connecting successive points
along the stroke, with rounded ends, each segment of constant width as
Immi Halupczok twisted the bytes to say:
>> I was looking at your code. I think it would be very useful to separate
>> conceptually the two changes, as you said before. It will also be very
>> useful to us that you describe (ideally in the log of the commit) a bit
>> in detail the changes. E
