Re: [Reproducible-builds] Bug#806331: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Ximin Luo
Thorsten Glaser: > Ximin Luo dixit: > >> needs to more clearly distinguish between the build and the host >> environment - like how compilers do. So for example, here the "most >> correct" solution would be to add a HOST_POSIX_SHELL and default this > > No, this is outside of the scope of autotoo

Re: Bug#806331: [Reproducible-builds] [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Thorsten Glaser
Paul Eggert dixit: > CONFIG_SHELL lets the user override Gnulib's guess in environments where the > guess is wrong. This sort of thing has been in Gnulib (and Autoconf) for ages, > I expect many people have grown used to it, and I'm leery of changing this > just > for the purpose of reproducible

Re: [Reproducible-builds] Bug#806331: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Thorsten Glaser
Ximin Luo dixit: >needs to more clearly distinguish between the build and the host >environment - like how compilers do. So for example, here the "most >correct" solution would be to add a HOST_POSIX_SHELL and default this No, this is outside of the scope of autotools and a common misuse of them

Re: Bug#806331: [Reproducible-builds] [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Thorsten Glaser
Ximin Luo dixit: >(Did you mean to add debian-bugs-dist and Jonathan Nieder on purpose >or by accident? I removed them, but feel free to add them back in.) I didn’t, maybe debbugs did. >In other words: in your scenario, one would not use $POSIX_SHELL but >some other specific test for those "othe

Re: [Reproducible-builds] Bug#806331: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Ximin Luo
Paul Eggert: > On 06/15/2016 01:44 PM, Ximin Luo wrote: >> In such a case, it is a bug to be using $POSIX_SHELL - which only tests for >> conformance with POSIX and not these "other bugs that make it unusable". > Gnulib can't test for all POSIX violations, only for the ones it knows about. > CONF

Re: Bug#806331: [Reproducible-builds] [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Ximin Luo
(Did you mean to add debian-bugs-dist and Jonathan Nieder on purpose or by accident? I removed them, but feel free to add them back in.) Thorsten Glaser: >> proposed patch affect your scenario? This is not about CONFIG_SHELL, > > It is. Straight from your diff: > >> for gl_cv_posix_shell i

Re: Bug#806331: [Reproducible-builds] [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Thorsten Glaser
Ximin Luo dixit: >I'm not sure if you understood what was being discussed. I understand it extremely well. >proposed patch affect your scenario? This is not about CONFIG_SHELL, It is. Straight from your diff: > for gl_cv_posix_shell in \ >-"$CONFIG_SHELL" "$SHELL" /bin/sh /bin/bas

Re: [Reproducible-builds] [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Ximin Luo
Thorsten Glaser: > Ximin Luo dixit: > >> bugs-gnulib, do you see any issue with this patch? The context is that > > [..] > > $CONFIG_SHELL should stay the ultimate instance. Users absolutely MUST > be able to override not-working-but-recognised-as-good-enough system > shells like /bin/sh with th

Re: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Thorsten Glaser
Ximin Luo dixit: >bugs-gnulib, do you see any issue with this patch? The context is that I’m not bugs-gnulib, but I’ve ported many a code using autotools to new platforms (MirBSD, MidnightBSD, Interix, Debian GNU/kFreeBSD), and also hacked autotools some. For added credibility, I’m the developer

Re: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Ximin Luo
+bugs-gnulib, reproducible-builds Lasse Collin: > On 2016-06-07 Ximin Luo wrote: >> I've attached a patch that makes m4/posix-shell.m4 try constant paths >> first. This should fix the issue. >> >> Upstream should also apply it - see more-stable-shell.patch. > > Thanks! > > posix-shell.m4 comes f

Re: [xz-devel] Re: xz-utils: make the selected POSIX shell stable accross build environments

2016-06-15 Thread Lasse Collin
On 2016-06-07 Ximin Luo wrote: > I've attached a patch that makes m4/posix-shell.m4 try constant paths > first. This should fix the issue. > > Upstream should also apply it - see more-stable-shell.patch. Thanks! posix-shell.m4 comes from gnulib so it would be nice if you could send the patch the