Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-26 Thread Martin K. Petersen
Arnd, > The get_seconds() helper returns an 'unsigned long' value, which can > overflow on 32-bit architectures. Since the interface we pass it into > already uses a 64-bit type, we can just use ktime_get_real_seconds() > instead. > > While we generally prefer local timestamps in CLOCK_MONOTONIC

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread James Smart
On 6/18/2018 8:29 AM, Arnd Bergmann wrote: The get_seconds() helper returns an 'unsigned long' value, which can overflow on 32-bit architectures. Since the interface we pass it into already uses a 64-bit type, we can just use ktime_get_real_seconds() instead. While we generally prefer local

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread Tyrel Datwyler
On 06/18/2018 08:29 AM, Arnd Bergmann wrote: > The get_seconds() helper returns an 'unsigned long' value, which can > overflow on 32-bit architectures. Since the interface we pass it into > already uses a 64-bit type, we can just use ktime_get_real_seconds() > instead. > > While we generally

Re: [Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-25 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[Y2038] [PATCH] scsi_transport_fc: use 64-bit timestamps consistently

2018-06-18 Thread Arnd Bergmann
The get_seconds() helper returns an 'unsigned long' value, which can overflow on 32-bit architectures. Since the interface we pass it into already uses a 64-bit type, we can just use ktime_get_real_seconds() instead. While we generally prefer local timestamps in CLOCK_MONOTONIC format