[Yade-dev] Mathr::ZERO_TOLERANCE vs Mathr::EPSILON

2018-11-15 Thread Jerome Duriez
Hello, Out of curiosity, why do we have both Mathr::ZERO_TOLERANCE and Mathr::EPSILON in the code [*] ? I would understand they're both intended to give an expected magnitude of rounding errors. (Note that ZERO_TOLERANCE is hardcoded as 1e-20, while EPSILON is ~ 2e-16 here) Both are used t

Re: [Yade-dev] Mathr::ZERO_TOLERANCE vs Mathr::EPSILON

2018-11-15 Thread Bruno Chareyre
Hi Jérôme, I don't know, but I guess they were introduced independently by different authors. I actually don't know why we would need to define tolerance at all, unless in very specific cases. For instance I judge that a line like this (ViscoelasticPM.cpp) is not only useless but actually wro

Re: [Yade-dev] Mathr::ZERO_TOLERANCE vs Mathr::EPSILON

2018-11-15 Thread Jerome Duriez
As for history/archeology, it looks like Vaclav introduced this code [*] (completing the previous commit [**]) I'd thus propose to get rid of ZERO_TOLERANCE at least, replacing with EPSILON where it is currently used. Thoughts ? (As for me, tolerance would for instance be  useful to know w

Re: [Yade-dev] Mathr::ZERO_TOLERANCE vs Mathr::EPSILON

2018-11-15 Thread Bruno Chareyre
On 11/15/18 5:16 PM, Jerome Duriez wrote: I'd thus propose to get rid of ZERO_TOLERANCE at least, replacing with EPSILON where it is currently used. Is it worth it?... (As for me, tolerance would for instance be  useful to know when an increasing value (x, increasing from x0 < a) can be dete

[Yade-dev] buildbot warnings in Yade on yade-full

2018-11-15 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4891 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: scheduler Build

[Yade-dev] buildbot warnings in Yade on yade-full

2018-11-15 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building Yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4892 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: The Nightly sch

[Yade-dev] buildbot warnings in Yade on yade-full

2018-11-15 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4893 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: The web-page 'r