Re: [Yade-dev] Please: we don't want compile warnings

2017-11-02 Thread Bruno Chareyre
Hi Anton, Your suggestion is sound. The problem is I'm not really sure we can really make all warnings disappear easily, because some are related to third-party headers (eigen, vtk,... example below). But yes, that would be an option if we could fix all. Bruno

Re: [Yade-dev] Please: we don't want compile warnings

2017-11-02 Thread Anton Gladky
Hi, I think it makes sense to enable "warnung-as-errors" for buildbot-builds. So the build will fail if new warnings were introduced in the last commits. Something like: cmake -DCMAKE_CXX_FLAGS="-Werror -Wall" ../src/to/yade Of course one need to fix all warnings before switching it on hardly.

[Yade-dev] Please: we don't want compile warnings

2017-11-02 Thread Bruno Chareyre
Hi all, I've seen an increase of compile warnings after some commits in the last months (members of the blamelist in bcc of this message ;)). I would like to recall that compile warnings should be considered like bugs and be fixed. Please make sure there is no compile warning before pushing