Re: [Yade-dev] Yade is not compatible with CGAL_4.13

2019-01-07 Thread Anton Gladky
Hello Janek, thanks for the fix! I have checked it and it really resolves the problem with the newer CGAL. I will reactivate CGAL-function for the Debian-build again. Regards Anton Am Mo., 7. Jan. 2019 um 13:44 Uhr schrieb Janek Kozicki : > > Bruno Chareyre said: (by the date of Sun, 6 Jan

Re: [Yade-dev] Yade is not compatible with CGAL_4.13

2019-01-06 Thread Bruno Chareyre
I forgot to answer the test coverage question: no, move() is not covered by any test, even indirectly. The function is not used in other parts of the code currently. B On Sun, 6 Jan 2019 at 13:44, Bruno Chareyre wrote: > Hi Janek, > I think that was the right fix, thanks. > Note that yade is

Re: [Yade-dev] Yade is not compatible with CGAL_4.13

2019-01-06 Thread Bruno Chareyre
Hi Janek, I think that was the right fix, thanks. Note that yade is not using the periodic triangulation implemented in CGAL [1] so there is no question on that point afaik. Bruno [1] that's because yade included periodicity years before cgal. I actually implemented a periodicity based on cgal's

Re: [Yade-dev] Yade is not compatible with CGAL_4.13

2019-01-04 Thread Janek Kozicki
It appears that this function move_point(…) had long been deprecated. I guess that's got something to do with previous modifications where we had to use weighted points differently. I propose to modify this line into calling move(…) instead. This isn't change like the previous one where the C++

Re: [Yade-dev] Yade is not compatible with CGAL_4.13

2018-12-07 Thread janek_listy
I'm looking into this. On 4 Dec 2018, 23:42 +0100, Anton Gladky , wrote: > Dear Yade developers, > > Yade fails to compile against newest CGAL_4,13, > The corresponding bug on Debian tracker is [#911685]. > > [#911685] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911685 > > Some relevant

[Yade-dev] Yade is not compatible with CGAL_4.13

2018-12-04 Thread Anton Gladky
Dear Yade developers, Yade fails to compile against newest CGAL_4,13, The corresponding bug on Debian tracker is [#911685]. [#911685] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911685 Some relevant lines are here. === CGT::SimpleVertexInfo, CGT::SimpleCellInfo>;