[Yade-dev] Why _utils.hpp and Shop.hpp ? Shop::getPorosity vs Shop__getPorosity

2018-07-16 Thread Jerome Duriez
Hi, What is the reason for having (for instance) Shop__getPorosity() in py/_utils.hpp/cpp and Shop::getPorosity() in pkg/dem/Shop.hpp / Shop_01.cpp ? I can see the latter has "scene" as an argument [1] in addition to "volume" (contrary to the former [2]), but probably this could be removed

[Yade-dev] buildbot warnings in Yade on yade-full

2018-07-16 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4680 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: The web-page

Re: [Yade-dev] Why _utils.hpp and Shop.hpp ? Shop::getPorosity vs Shop__getPorosity

2018-07-16 Thread Jan Stránský
Hi Jerome, below please find my opinion. If the approach proposed by you works and does not break existing code (or it is not easy to fix it), I would have nothing against the refactoring. What is the reason for having (for instance) Shop__getPorosity() in > py/_utils.hpp/cpp and

Re: [Yade-dev] Why _utils.hpp and Shop.hpp ? Shop::getPorosity vs Shop__getPorosity

2018-07-16 Thread Jerome Duriez
Thanks for the 1st opinion, Jan. To be clear, I do not want to propose any changes, it's just I'm writing these days C++ functions with Python exposure, and I try to understand the rationale (if any) behind this architecture before I reproduce it... Jérôme -- Chargé de Recherche /

[Yade-dev] buildbot warnings in Yade on yade-full

2018-07-16 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4677 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: scheduler

[Yade-dev] buildbot warnings in Yade on yade-full

2018-07-16 Thread buildbot
The Buildbot has detected a problem in the build on builder yade-full while building yade. Full details are available at: https://yade-dem.org/buildbot/builders/yade-full/builds/4678 Buildbot URL: https://yade-dem.org/buildbot/ Buildslave for this Build: r0calcul9 Build Reason: scheduler