Reviewed: https://review.openstack.org/265101 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=34eee037853accd3e7603c4c78c504eb33f81ed1 Submitter: Jenkins Branch: master
commit 34eee037853accd3e7603c4c78c504eb33f81ed1 Author: Tom Fifield <t...@openstack.org> Date: Fri Jan 8 14:32:25 2016 +0800 Fix i18n msgfmt bug in launch-instance You must use the the same arguments in both msgid and msgid_plural, because some languages may have more than just two plural forms. The string in launch-instance-model did not follow this convention so caused errors with the i18n machinery. Change-Id: If31178cd107b3ba44f807fed0d8c881ec2b11aa5 Closes-Bug: 1532092 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1532092 Title: Different arguments in msgid1 and msgid2 of ngettext() caused msgfmt fail Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Hi, The following format in openstack_dashboard/locale/djangojs.pot caused the fail of msgfmt, which blocked the import of translations. #: dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js:255 #, python-format msgid "Instance launched." msgid_plural "%s instances launched." msgstr[0] "" msgstr[1] "" The error log file is: http://logs.openstack.org/77/259677/20/check /gate-horizon-dsvm- integration/814d701/logs/devstacklog.txt.gz#_2016-01-07_06_48_30_569. The source code is line 255 in openstack_dashboard/dashboards/project/static/dashboard/project/workflow /launch-instance/launch-instance-model.service.js var message = ngettext('Instance launched.', '%s instances launched.', numberInstances); It should be changed to : var message = ngettext('%s instance launched.', '%s instances launched.', numberInstances); Please keep in mind that you must use the the same arguments in both msgid and msgid_plural, because some languages may have more than just two forms. Regards Daisy To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1532092/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp