Reviewed: https://review.openstack.org/266816 Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=0bf94d0b41f299acd580ef45ae0eeacbfdabe7ea Submitter: Jenkins Branch: master
commit 0bf94d0b41f299acd580ef45ae0eeacbfdabe7ea Author: Zhou Zhihong <zhouzhih...@cmss.chinamobile.com> Date: Tue Jan 19 19:06:24 2016 -0800 Add check for listener's admin_state_up status Add check for listener's admin_state_up status, so that only listener which admin_state_up==True can be write to the haproxy config file. Change-Id: I4b27cb0638fbd7f8d59829e8ddce8e7387b5f390 Closes-Bug: #1533108 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1533108 Title: [lbaasv2]The admin_state_up=False of listener didn't take effect if there were two listeners under one loadbalancer Status in neutron: Fix Released Bug description: ===== This issue exists on Master. ===== Reproduce steps: 1.Create a loadbalancer LB1 2.Create a listener Listener1 under LB1 3.Create another listener Listener2 under LB1 4.Create pools and members under Listener1 and Listener2 5.Change admin_state_up of Listener2 to False After these operations, Listener2 can still be accessed. And if I change the admin_state_up of both Listener1 and Listener2 to False, it works, neither of them can be accessed. ===== [root@controller ~]# neutron lbaas-loadbalancer-show lb1 +---------------------+------------------------------------------------+ | Field | Value | +---------------------+------------------------------------------------+ | admin_state_up | True | | description | | | id | ef1aaf1f-f1a0-4297-b2a2-19d3ade2cf61 | | listeners | {"id": "a1e46e6a-37e9-4a60-ab61-75905217948e"} | | | {"id": "da1c0c06-bb78-4ff1-acfa-735d34b77557"} | | name | lb1 | | operating_status | ONLINE | | provider | haproxy | | provisioning_status | ACTIVE | | tenant_id | f9969a4c930c410f8c508a54fa67f775 | | vip_address | 192.168.1.11 | | vip_port_id | f820d46b-96ee-431c-85c9-a50cb5af988e | | vip_subnet_id | b4b63f9a-8cab-40b5-bdb7-db125b06be17 | +---------------------+------------------------------------------------+ [root@controller ~]# [root@controller ~]# neutron lbaas-listener-show a1e46e6a-37e9-4a60-ab61-75905217948e +--------------------------+------------------------------------------------+ | Field | Value | +--------------------------+------------------------------------------------+ | admin_state_up | True | | connection_limit | 0 | | default_pool_id | 34c9e4fd-4ee4-4b1d-b646-a28b2c4c732a | | default_tls_container_id | | | description | | | id | a1e46e6a-37e9-4a60-ab61-75905217948e | | loadbalancers | {"id": "ef1aaf1f-f1a0-4297-b2a2-19d3ade2cf61"} | | name | listener1 | | protocol | TCP | | protocol_port | 22 | | sni_container_ids | | | tenant_id | f9969a4c930c410f8c508a54fa67f775 | +--------------------------+------------------------------------------------+ [root@controller ~]# [root@controller ~]# neutron lbaas-listener-show da1c0c06-bb78-4ff1-acfa-735d34b77557 +--------------------------+------------------------------------------------+ | Field | Value | +--------------------------+------------------------------------------------+ | admin_state_up | False | | connection_limit | -1 | | default_pool_id | e5055294-fccd-4eb5-82fa-924906251fd4 | | default_tls_container_id | | | description | | | id | da1c0c06-bb78-4ff1-acfa-735d34b77557 | | loadbalancers | {"id": "ef1aaf1f-f1a0-4297-b2a2-19d3ade2cf61"} | | name | listener2 | | protocol | HTTP | | protocol_port | 80 | | sni_container_ids | | | tenant_id | f9969a4c930c410f8c508a54fa67f775 | +--------------------------+------------------------------------------------+ [root@controller ~]# [root@controller ~]# curl http://172.16.102.229:80/index.html test [root@controller ~]# To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1533108/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp