Reviewed: https://review.openstack.org/286384
Committed:
https://git.openstack.org/cgit/openstack/neutron/commit/?id=cd7be292a8d1fb4ce913c4e7fbfc55fda033ffbe
Submitter: Jenkins
Branch: master
commit cd7be292a8d1fb4ce913c4e7fbfc55fda033ffbe
Author: Brandon Logan <brandon.lo...@rackspace.com>
Date: Mon Feb 29 23:11:18 2016 -0600
Check if plugin supports starting rpc listeners
When neutron starts an rpc worker, it checks if the plugin has the method
"start_rpc_listeners". Since most plugins inherit from a base class, and
that base class implements the start_rpc_listeners method and raises
NotImplementedError, the rpc worker will attempt to call that method.
It should just catch the NotImplementedError and continue on.
Change-Id: Ie1830b6140acffffd0f283a0d8eefa52067f7650
Closes-Bug: 1551542
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1551542
Title:
need to check if a plugin's start rpc listeners is supported before
trying to start it
Status in neutron:
Fix Released
Bug description:
This showed up on a new service plugin being created that did not need
to start rpc workers. It did not implement the start_rpc_listeners
method so the base class has it raise NotImplemented.
The neutron.service.RpcWorker.start method should check if the plugin
supports it by using the plugin.rpc_workers_supported method.
https://github.com/openstack/neutron/blob/master/neutron/neutron_plugin_base_v2.py#L389-L402
2016-03-01 11:35:19.983 ERROR oslo_service.service [-] Error starting
thread.
2016-03-01 11:35:19.983 TRACE oslo_service.service Traceback (most recent
call last):
2016-03-01 11:35:19.983 TRACE oslo_service.service File
"/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 680, in
run_service
2016-03-01 11:35:19.983 TRACE oslo_service.service service.start()
2016-03-01 11:35:19.983 TRACE oslo_service.service File
"/opt/stack/neutron/neutron/service.py", line 142, in start
2016-03-01 11:35:19.983 TRACE oslo_service.service servers =
getattr(plugin, self.start_listeners_method)()
2016-03-01 11:35:19.983 TRACE oslo_service.service File
"/opt/stack/neutron/neutron/neutron_plugin_base_v2.py", line 377, in
start_rpc_listeners
2016-03-01 11:35:19.983 TRACE oslo_service.service raise
NotImplementedError()
2016-03-01 11:35:19.983 TRACE oslo_service.service NotImplementedError
2016-03-01 11:35:19.983 TRACE oslo_service.service
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1551542/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
