Reviewed: https://review.openstack.org/564649 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=b2179479db28bb222412f700c09985578b935084 Submitter: Zuul Branch: master
commit b2179479db28bb222412f700c09985578b935084 Author: Brian Rosmaita <rosmaita.foss...@gmail.com> Date: Thu Apr 26 19:04:58 2018 -0400 Add time-bounded wait-for-status to func tests Replace strategy of time.sleep(s_value) waiting for an image to reach 'active' with a time-bounded wait-for-status loop function. That way we can have a more generous s_value, which seems to sometimes be needed in the gates, without having to use that much time on every run. I picked the initial s_value as 4x what was in the current code, though given that some of the other gate tests run >1 hour, we could easily make it 600 sec without lengthening the current minimum time-to-verification of a patch. Closes-bug: #1767142 Change-Id: Ib771079348d22212c7b6d90fa89e7fd4161422d3 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1767142 Title: functional tests need time-bounded wait-for-status Status in Glance: Fix Released Bug description: Seeing occasional functional test failures in the image import tests (for example [0]). They currently sleep to wait for the server to complete an action [1], but sometimes the action apparently takes longer than expected. Would be good to introduce some kind of time-bounded wait-for-status function instead of the sleep for these tests. [0] http://logs.openstack.org/77/564077/4/check/openstack-tox- functional/56d5a64/job-output.txt.gz#_2018-04-26_01_49_20_067643 [1] https://github.com/openstack/glance/blob/8a2d1542348e8aaaee163ba629fd37c534d469d9/glance/tests/functional/v2/test_images.py#L383 To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1767142/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp