[Yahoo-eng-team] [Bug 1784022] Re: Failed forced live migration does not rollback doubled up allocations in placement

2018-07-27 Thread Matt Riedemann
This isn't an issue after all because we move the allocations on the source node from the instance to the migration *before* we do the copy: https://github.com/openstack/nova/blob/6be7f7248fb1c2bbb890a0a48a424e205e173c9c/nova/conductor/tasks/live_migrate.py#L82 https://github.com/openstack/nova/b

[Yahoo-eng-team] [Bug 1784022] Re: Failed forced live migration does not rollback doubled up allocations in placement

2018-07-27 Thread Matt Riedemann
Looks like this was regressed in Queens: https://review.openstack.org/#/c/507638/29/nova/compute/manager.py@a6289 And I even pointed it out on the review but we didn't think about the forced live migration case: https://review.openstack.org/#/c/507638/25/nova/compute/manager.py@6252 ** Also aff