[HELP] Review request

2019-05-10 Thread Wanqiang Ji
Hi folks, Can someone help to review these patches? Fix Scheduler Page can't display the right page by query string Fix JavaDoc error in TestSchedulerOvercommit Clean up code long if-else chain in Ap

Re: [HELP] Review request

2019-05-10 Thread Giovanni Matteo Fumarola
Hi Wanqiang, I will take a look at these. On Fri, May 10, 2019 at 7:30 AM Wanqiang Ji wrote: > Hi folks, > Can someone help to review these patches? > Fix Scheduler Page can't display the right page by query string > > Fix JavaDoc error in TestS

[HELP] Review request for YARN-9214 and YARN-9401

2019-03-26 Thread Wanqiang Ji
Hi folks, Can someone help to review YARN-9214 and YARN-9401? YARN-9214. Add AbstractYarnScheduler#getValidQueues method to resolve duplicate code YARN-9401. Fix `yarn version` print the version info is the same as `hadoop version` -Wanqiang Ji

Re: [HELP] Review request for YARN-9214 and YARN-9401

2019-03-26 Thread Szilard Nemeth
Hi, Sure, I can do that tomorrow. Szilard On Tue, Mar 26, 2019 at 3:41 PM Wanqiang Ji wrote: > Hi folks, > > Can someone help to review YARN-9214 and YARN-9401? > YARN-9214. Add AbstractYarnScheduler#getValidQueues method to resolve > duplicate code > YARN-9401. Fix `yarn version` print the ve

Re: [HELP] Review request for YARN-9214 and YARN-9401

2019-03-31 Thread Wanqiang Ji
Thanks for Szilard review (non-binding) these patches. Does anyone help to review and submit? On Tue, Mar 26, 2019 at 10:57 PM Szilard Nemeth wrote: > Hi, > > Sure, I can do that tomorrow. > > Szilard > > On Tue, Mar 26, 2019 at 3:41 PM Wanqiang Ji wrote: > >> Hi folks, >> >> Can someone help t