Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-04 Thread slfan1989
Thank you all very much for helping with the review and vote! I will conclude the voting for Hadoop-thirdparty-1.2.0-RC0 and open the voting for Hadoop-thirdparty-1.2.0-RC1. Thank you for the feedback on the code diff, Ayush. I have already submitted the changes to the Dockerfile and create-relea

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-04 Thread Shuyan Zhang
+1 (non-binding) - Verified hashes - LICENSE and NOTICE are included. - Rat check is ok. `mvn clean apache-rat:check` - `mvn clean install` works well slfan1989 于2024年2月2日周五 11:11写道: > Thank you very much for the review! I will avoid the diff. > > Best Regards, > Shilun Fan. > > On Fri, Feb 2,

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-01 Thread slfan1989
Thank you very much for the review! I will avoid the diff. Best Regards, Shilun Fan. On Fri, Feb 2, 2024 at 9:59 AM Takanobu Asanuma wrote: > It also looks good to me, except for the diff. > > * Verified signatures and hashes > * Reviewed the documents > * Successfully built from source with `m

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-01 Thread Takanobu Asanuma
It also looks good to me, except for the diff. * Verified signatures and hashes * Reviewed the documents * Successfully built from source with `mvn clean install` * Successfully compiled Hadoop trunk and branch-3.4 using the Hadoop thirdparty 1.2.0 Anyway, since hadoop-thirdparty-1.1.1 has some h

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-01 Thread slfan1989
Thank you for helping to review Hadoop-Thirdparty-1.2.0-RC0 and providing feedback! I followed the "how to release" documentation and tried to package it using create-release and Dockerfile, but I couldn't successfully package it directly. Some modifications are required before compilation. I shou

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-01 Thread Ayush Saxena
There is some diff b/w the git tag & the src tar, the Dockerfile & the create-release are different, Why? Files hadoop-thirdparty/dev-support/bin/create-release and hadoop-thirdparty-1.2.0-src/dev-support/bin/create-release differ Files hadoop-thirdparty/dev-support/docker/Dockerfile and hadoop-t

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-02-01 Thread Xiaoqiao He
Gentle ping. @Ayush Saxena @Steve Loughran @inigo...@apache.org @Masatake Iwasaki and some other folks. On Wed, Jan 31, 2024 at 10:17 AM slfan1989 wrote: > Thank you for the review and vote! Looking forward to other forks helping > with voting and verification. > > Best Regards, > Shilun Fan

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-01-30 Thread slfan1989
Thank you for the review and vote! Looking forward to other forks helping with voting and verification. Best Regards, Shilun Fan. On Tue, Jan 30, 2024 at 6:20 PM Xiaoqiao He wrote: > Thanks Shilun for driving it and making it happen. > > +1(binding). > > [x] Checksums and PGP signatures are val

Re: [VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-01-30 Thread Xiaoqiao He
Thanks Shilun for driving it and making it happen. +1(binding). [x] Checksums and PGP signatures are valid. [x] LICENSE files exist. [x] NOTICE is included. [x] Rat check is ok. `mvn clean apache-rat:check` [x] Built from source works well: `mvn clean install` [x] Built Hadoop trunk with updated

[VOTE] Release Apache Hadoop Thirdparty 1.2.0 RC0

2024-01-29 Thread slfan1989
Hi folks, Xiaoqiao He and I have put together a release candidate (RC0) for Hadoop Thirdparty 1.2.0. The RC is available at: https://dist.apache.org/repos/dist/dev/hadoop/hadoop-thirdparty-1.2.0-RC0 The RC tag is https://github.com/apache/hadoop-thirdparty/releases/tag/release-1.2.0-RC0 The mav