Jian He created YARN-6342: ----------------------------- Summary: Issues in TimelineClientImpl#TimelineClientImpl Key: YARN-6342 URL: https://issues.apache.org/jira/browse/YARN-6342 Project: Hadoop YARN Issue Type: Bug Reporter: Jian He
Found these with [~rohithsharma] while browsing the code - In stop: it calls shutdownNow which doens't wait for pending tasks, should it use shutdown instead ? {code} public void stop() { LOG.info("Stopping TimelineClient."); executor.shutdownNow(); try { executor.awaitTermination(DRAIN_TIME_PERIOD, TimeUnit.MILLISECONDS); } catch (InterruptedException e) { {code } - In createRunnable: If any exception happens when publish one entity (ServiceTimelineEvent), the thread exists. I think it should try best effort to continue publish the timeline events, one failure should not cause all followup events not published. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org