[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-18 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.008.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Updated] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6781: -- Attachment: YARN-6781-YARN-3926.004.patch > ResourceUtils.initializeResourcesMap() takes an unnecessary M

[jira] [Commented] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129058#comment-16129058 ] Yu-Tang Lin commented on YARN-6885: --- I thought the reason make the two fail cases have no

[jira] [Updated] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6781: -- Attachment: YARN-6781-YARN-3926.003.patch > ResourceUtils.initializeResourcesMap() takes an unnecessary M

[jira] [Commented] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128898#comment-16128898 ] Yu-Tang Lin commented on YARN-6781: --- Thanks [#Sunil G ] for your suggestion, but I notice

[jira] [Comment Edited] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128898#comment-16128898 ] Yu-Tang Lin edited comment on YARN-6781 at 8/16/17 2:55 PM: Tha

[jira] [Commented] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-16 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128586#comment-16128586 ] Yu-Tang Lin commented on YARN-6781: --- Hi [#Sunil G ],  I just checked the code of these tw

[jira] [Commented] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-15 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128200#comment-16128200 ] Yu-Tang Lin commented on YARN-6781: --- Hi,[#Daniel Templeton ], looks like jenkins is OK no

[jira] [Updated] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-15 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6781: -- Attachment: YARN-6781-YARN-3926.002.patch > ResourceUtils.initializeResourcesMap() takes an unnecessary M

[jira] [Updated] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-15 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6781: -- Attachment: YARN-6781.001.patch > ResourceUtils.initializeResourcesMap() takes an unnecessary Map paramet

[jira] [Assigned] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-15 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin reassigned YARN-6781: - Assignee: Yu-Tang Lin > ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

[jira] [Commented] (YARN-6781) ResourceUtils.initializeResourcesMap() takes an unnecessary Map parameter

2017-08-15 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127433#comment-16127433 ] Yu-Tang Lin commented on YARN-6781: --- Hi Daniel, thanks for submit this issue. I would lik

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-14 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.007.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Comment Edited] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-14 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124866#comment-16124866 ] Yu-Tang Lin edited comment on YARN-6885 at 8/14/17 2:59 PM: mod

[jira] [Comment Edited] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-14 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124866#comment-16124866 ] Yu-Tang Lin edited comment on YARN-6885 at 8/14/17 2:38 PM: mod

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-13 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.006.patch modify some lines of code base on code review's result. > AllocationFile

[jira] [Commented] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122737#comment-16122737 ] Yu-Tang Lin commented on YARN-6885: --- Hi [#Daniel Templeton], thanks for the comment! I pu

[jira] [Comment Edited] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121920#comment-16121920 ] Yu-Tang Lin edited comment on YARN-6885 at 8/10/17 5:08 PM: kee

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.005.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: (was: YARN-6885.004.patch) > AllocationFileLoaderService.loadQueue() should use a switch

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: (was: YARN-6885.003.patch) > AllocationFileLoaderService.loadQueue() should use a switch

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.004.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Commented] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-10 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121246#comment-16121246 ] Yu-Tang Lin commented on YARN-6885: --- Due to this patch is a minor refactor of two functio

[jira] [Issue Comment Deleted] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Comment: was deleted (was: minor refactor the old code, no new test case is needed.) > AllocationFileLoa

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: (was: YARN-6885.003.patch) > AllocationFileLoaderService.loadQueue() should use a switch

[jira] [Comment Edited] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121154#comment-16121154 ] Yu-Tang Lin edited comment on YARN-6885 at 8/10/17 6:45 AM: pat

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.003.patch minor refactor the old code, no new test case is needed. > AllocationFil

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.003.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: (was: YARN-6885.002.patch) > AllocationFileLoaderService.loadQueue() should use a switch

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: (was: 0001-YARN-6885.patch) > AllocationFileLoaderService.loadQueue() should use a switch

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-09 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: YARN-6885.002.patch > AllocationFileLoaderService.loadQueue() should use a switch statement i

[jira] [Updated] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-08 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Tang Lin updated YARN-6885: -- Attachment: 0001-YARN-6885.patch > AllocationFileLoaderService.loadQueue() should use a switch statement

[jira] [Commented] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-08 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119322#comment-16119322 ] Yu-Tang Lin commented on YARN-6885: --- I noticed that reloadAllocations had the similar cod

[jira] [Commented] (YARN-6885) AllocationFileLoaderService.loadQueue() should use a switch statement in the main tag parsing loop instead of the if/else-if/...

2017-08-07 Thread Yu-Tang Lin (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117743#comment-16117743 ] Yu-Tang Lin commented on YARN-6885: --- Thanks to Daniel for filling this form, I would like