[
https://issues.apache.org/jira/browse/YARN-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512325#comment-17512325
]
Benjamin Teke edited comment on YARN-11094 at 3/25/22, 11:11 AM:
-----------------------------------------------------------------
Thanks [~snemeth] for working on this, +1 for the follow-up, committed to trunk.
[~quapaw] thanks for the review, just missed it. Talked with [~snemeth] about
this, and because most of these issues are reappearing because of moving the
original code we thought it's cleaner to fix the issues together in a clean up
jira after all of the related changes are merged.
was (Author: bteke):
Thanks [~snemeth] for working on this, +1 for the follow-up, committed to trunk.
> Follow up changes for YARN-10547
> --------------------------------
>
> Key: YARN-11094
> URL: https://issues.apache.org/jira/browse/YARN-11094
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler-load-simulator
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-11094.001.patch, YARN-11094.002.patch
>
>
> As a follow up of YARN-10547, we need to fix the raw use of Map across the
> following classes:
> - AMDefinitionSLS
> - SLSRunner
> See [this
> comment|https://issues.apache.org/jira/browse/YARN-10547?focusedCommentId=17510839&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17510839]
> for details.
> The following methods are affected:
> - org.apache.hadoop.yarn.sls.AMDefinitionFactory#createFromSlsTrace
> - org.apache.hadoop.yarn.sls.AMDefinitionFactory#getAMContainerResourceSLS
> - org.apache.hadoop.yarn.sls.AMDefinitionSLS#getTaskContainers
> - Methods of TaskContainerDefinition.Builder
> - org.apache.hadoop.yarn.sls.AMDefinitionSLS.Builder#create
> - org.apache.hadoop.yarn.sls.SLSRunner#startAMFromSLSTrace
> Moreover, some generic cleanup in SLSRunner could be performed to eliminate:
> 1. Redundant @SuppressWarnings("unchecked") annotations
> 2. Explicit type arguments for some collections
> 3. Remove exceptions from methods that never throwing them
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
