[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177485#comment-17177485
]
Bilwa S T commented on YARN-10336:
--
Thanks [~elgoiri] and [~hemanthboyina] for review
> RM page should
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177241#comment-17177241
]
Hemanth Boyina commented on YARN-10336:
---
committed to trunk and branch 3.3 , thanks [~BilwaST] for
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177233#comment-17177233
]
Hemanth Boyina commented on YARN-10336:
---
+1 , will commit shortly
> RM page should throw exception
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177222#comment-17177222
]
Íñigo Goiri commented on YARN-10336:
+1 on [^YARN-10336.003.patch].
> RM page should throw
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175832#comment-17175832
]
Hadoop QA commented on YARN-10336:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175735#comment-17175735
]
Bilwa S T commented on YARN-10336:
--
Thanks [~elgoiri] for review.
# Using singletonMap would return
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175700#comment-17175700
]
Íñigo Goiri commented on YARN-10336:
The tests looks good, couple minor things:
* Add license to the
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175671#comment-17175671
]
Hadoop QA commented on YARN-10336:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175602#comment-17175602
]
Bilwa S T commented on YARN-10336:
--
Added UT
> RM page should throw exception when command injected in
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169546#comment-17169546
]
Bilwa S T commented on YARN-10336:
--
Hi [~hemanthboyina]
No ...[] character is not injected.
> RM page
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169498#comment-17169498
]
Hemanth Boyina commented on YARN-10336:
---
thanks for the report [~Rajshree] , thanks for the patch
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168504#comment-17168504
]
Bilwa S T commented on YARN-10336:
--
Attached patch and test proof !testproof.png!
> RM page should
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168500#comment-17168500
]
Bilwa S T commented on YARN-10336:
--
Attaching patch and test proof !testproof.png!
> RM page should
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150315#comment-17150315
]
Bilwa S T commented on YARN-10336:
--
cc [~brahmareddy]
> RM page should throw exception when command
[
https://issues.apache.org/jira/browse/YARN-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17150303#comment-17150303
]
Bilwa S T commented on YARN-10336:
--
This should be handled same way as how NodesPage is handled if
15 matches
Mail list logo