[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303365#comment-17303365
]
Peter Bacsko commented on YARN-10497:
-
+1
Thanks [~wangda] / [~zhuqi] for the patch and [~gandras],
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303324#comment-17303324
]
Hadoop QA commented on YARN-10497:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303247#comment-17303247
]
Qi Zhu commented on YARN-10497:
---
Thanks [~pbacsko] for confirm.
> Fix an issue in CapacityScheduler
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303245#comment-17303245
]
Peter Bacsko commented on YARN-10497:
-
I think it's good. Let's wait for Jenkins and I'll commit it.
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303208#comment-17303208
]
Qi Zhu commented on YARN-10497:
---
Thanks [~gandras] for review.
I removed the mocking logic in
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303190#comment-17303190
]
Andras Gyori commented on YARN-10497:
-
Thank you [~zhuqi], seems to be a straightforward change,
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298128#comment-17298128
]
Hadoop QA commented on YARN-10497:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298059#comment-17298059
]
Qi Zhu commented on YARN-10497:
---
[~shuzirra] [~pbacsko]
Updated a patch to use getTrimmedStringCollection
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297915#comment-17297915
]
Qi Zhu commented on YARN-10497:
---
[~shuzirra] [~pbacsko]
Is this going on? I can help rebase and fixed for
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262985#comment-17262985
]
Wangda Tan commented on YARN-10497:
---
[~shuzirra], [~pbacsko] can you review the latest patch when you
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238837#comment-17238837
]
Wangda Tan commented on YARN-10497:
---
[~shuzirra], I would still prefer to use the
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238683#comment-17238683
]
Gergely Pollak commented on YARN-10497:
---
[~wangda] you didn't use getStringCollection, but the
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238465#comment-17238465
]
Hadoop QA commented on YARN-10497:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238410#comment-17238410
]
Wangda Tan commented on YARN-10497:
---
Attached ver.3 patch, fixed checkstyle, and unit test.
> Fix an
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238407#comment-17238407
]
Hadoop QA commented on YARN-10497:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238365#comment-17238365
]
Wangda Tan commented on YARN-10497:
---
Patch 002, fixed check style issue, and unit test issues. (cc:
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237479#comment-17237479
]
Gergely Pollak commented on YARN-10497:
---
[~wangda]Thank you for the patch!
There is a
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236692#comment-17236692
]
Peter Bacsko commented on YARN-10497:
-
Thanks for the patch [~wangda].
Just two things:
# Please
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236566#comment-17236566
]
Hadoop QA commented on YARN-10497:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17236509#comment-17236509
]
Wangda Tan commented on YARN-10497:
---
[~snemeth], [~pbacsko], [~shuzirra], [~bteke] can you help to
20 matches
Mail list logo