[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271186#comment-17271186
]
zhuqi commented on YARN-10531:
--
Thanks [~wangda] for final review.
> Be able to disable
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269469#comment-17269469
]
Wangda Tan commented on YARN-10531:
---
+1, thanks [~zhuqi], will get it in later today.
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269053#comment-17269053
]
Hadoop QA commented on YARN-10531:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vo
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269052#comment-17269052
]
Hadoop QA commented on YARN-10531:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269009#comment-17269009
]
zhuqi commented on YARN-10531:
--
[~wangda]
I have fixed above, in latest patch.
> Be able t
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268755#comment-17268755
]
Wangda Tan commented on YARN-10531:
---
Thanks [~zhuqi],
Two minor comments:
1) Parent
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268457#comment-17268457
]
zhuqi commented on YARN-10531:
--
cc [~wangda] [~sunilg]
If you any other advice for this?
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267960#comment-17267960
]
Hadoop QA commented on YARN-10531:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267852#comment-17267852
]
Hadoop QA commented on YARN-10531:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267771#comment-17267771
]
zhuqi commented on YARN-10531:
--
[~BilwaST]
Thanks a lot for your review, fix checkstyle in
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267763#comment-17267763
]
Bilwa S T commented on YARN-10531:
--
Hi [~zhuqi]
Thanks for the patch. patch looks good
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266853#comment-17266853
]
Hadoop QA commented on YARN-10531:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266799#comment-17266799
]
zhuqi commented on YARN-10531:
--
[~wangda]
I have rebased it, i have also added a new auto c
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266294#comment-17266294
]
Wangda Tan commented on YARN-10531:
---
[~zhuqi], I haven't reviewed details of the patch
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248823#comment-17248823
]
zhuqi commented on YARN-10531:
--
[~wangda]
Attach a latest patch, to make unit test more cl
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248318#comment-17248318
]
Hadoop QA commented on YARN-10531:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248297#comment-17248297
]
zhuqi commented on YARN-10531:
--
[~wangda] [~pbacsko] [~tangzhankun]
I submit a patch to di
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248260#comment-17248260
]
zhuqi commented on YARN-10531:
--
[~wangda]
I'm glad to take this.
Thanks.
> Be able to dis
[
https://issues.apache.org/jira/browse/YARN-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248149#comment-17248149
]
Wangda Tan commented on YARN-10531:
---
[~zhuqi] do you want to take a try on this one?
19 matches
Mail list logo