[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301831#comment-17301831
]
Eric Payne commented on YARN-10588:
---
OK. Thanks [~BilwaST] and [~Jim_Brennan]!
+1
I will commit this
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301434#comment-17301434
]
Bilwa S T commented on YARN-10588:
--
Thanks [~Jim_Brennan] and [~epayne] for review comments.
I have
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300968#comment-17300968
]
Jim Brennan commented on YARN-10588:
Yes. I think it is ok to do it as a separate Jira. We may
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300876#comment-17300876
]
Eric Payne commented on YARN-10588:
---
bq. I wonder if we should be looping over the first
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298991#comment-17298991
]
Jim Brennan commented on YARN-10588:
This looks good, but I have one question about
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298332#comment-17298332
]
Eric Payne commented on YARN-10588:
---
Thanks [~BilwaST] for reporting the issue and the fixes! The
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298159#comment-17298159
]
Eric Payne commented on YARN-10588:
---
[~BilwaST], sorry for the delay. I will look at this today.
>
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298009#comment-17298009
]
Bilwa S T commented on YARN-10588:
--
Hi [~Jim_Brennan]
can you please take a look at this Jira when you
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295089#comment-17295089
]
Hadoop QA commented on YARN-10588:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294998#comment-17294998
]
Bilwa S T commented on YARN-10588:
--
[~epayne]
I have updated the patch. Please take a look at it.
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293221#comment-17293221
]
Eric Payne commented on YARN-10588:
---
[~BilwaST], sorry for the delay in replying.
bq. Changing
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286446#comment-17286446
]
Bilwa S T commented on YARN-10588:
--
[~Jim_Brennan] [~epayne]
Changing
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282988#comment-17282988
]
Bilwa S T commented on YARN-10588:
--
[~epayne]
Modifying *DominantResourceCalculator#isInvalidDivisor*
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282737#comment-17282737
]
Eric Payne commented on YARN-10588:
---
I see. Thanks [~BilwaST] for the explanation. After looking at the
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282328#comment-17282328
]
Bilwa S T commented on YARN-10588:
--
Hi [~epayne]
I added change in FicaSchedulerApp.java as same issue
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282097#comment-17282097
]
Eric Payne commented on YARN-10588:
---
[~Jim_Brennan], it does seem like
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279997#comment-17279997
]
Jim Brennan commented on YARN-10588:
Thanks for reporting this and putting up the patch [~BilwaST]!
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278786#comment-17278786
]
Bilwa S T commented on YARN-10588:
--
cc [~epayne] [~Jim_Brennan]
> Percentage of queue and cluster is
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277260#comment-17277260
]
Hadoop QA commented on YARN-10588:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277110#comment-17277110
]
Bilwa S T commented on YARN-10588:
--
Fixed all UT's in .003 patch
> Percentage of queue and cluster is
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277104#comment-17277104
]
Hadoop QA commented on YARN-10588:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275559#comment-17275559
]
Hadoop QA commented on YARN-10588:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269584#comment-17269584
]
Hadoop QA commented on YARN-10588:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269264#comment-17269264
]
Bilwa S T commented on YARN-10588:
--
I think calc.isInvalidDivisor(cluster) check can be removed as
24 matches
Mail list logo