[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-31 Thread Szilard Nemeth (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312407#comment-17312407 ] Szilard Nemeth commented on YARN-10597: --- Thanks [~shuzirra] for working on this. Latest patch LGTM,

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-25 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308884#comment-17308884 ] Ahmed Hussein commented on YARN-10597: -- Thanks [~shuzirra] for the fix. +1 (non-binding) >

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308012#comment-17308012 ] Gergely Pollak commented on YARN-10597: --- I checked and [~ahussein] was right, the configuration

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307968#comment-17307968 ] Hadoop QA commented on YARN-10597: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-22 Thread Gergely Pollak (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17306175#comment-17306175 ] Gergely Pollak commented on YARN-10597: --- [~ahussein] thank you for the feedback, I'll take a look

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-19 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305024#comment-17305024 ] Ahmed Hussein commented on YARN-10597: -- That's interesting. I ran the unit tests in YARN-10425 from

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-19 Thread Peter Bacsko (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304971#comment-17304971 ] Peter Bacsko commented on YARN-10597: - [~shuzirra] is it really that simple? You told me that there

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-18 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304445#comment-17304445 ] Ahmed Hussein commented on YARN-10597: -- Thanks [~shuzirra] for the patch. It is fine to ignore the

[jira] [Commented] (YARN-10597) CSMappingPlacementRule should not create new instance of Groups

2021-03-17 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303841#comment-17303841 ] Hadoop QA commented on YARN-10597: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||